node/chainstate: Decouple from GetTimeMillis

Author: kwvg

src/init.cpp

@@ -1865,6 +1865,7 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info)
 
         uiInterface.InitMessage(_("Loading block index…").translated);
 
+        const auto load_block_index_start_time{SteadyClock::now()};
         bool rv = LoadChainstate(fLoaded,
                                  strLoadError,
                                  fReset,
@@ -1879,6 +1880,9 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info)
                                  nCoinDBCache,
                                  nCoinCacheUsage);
         if (!rv) return false;
+        if (fLoaded) {
+            LogPrintf(" block index %15dms\n", Ticks<std::chrono::milliseconds>(SteadyClock::now() - load_block_index_start_time));
+        }
 
         if (!fLoaded && !ShutdownRequested()) {
             // first suggest a reindex

src/node/chainstate.cpp

@@ -7,7 +7,7 @@
 #include <chainparams.h> // for CChainParams
 #include <deploymentstatus.h> // for DeploymentActiveAfter
 #include <rpc/blockchain.h> // for RPCNotifyBlockChange
-#include <util/time.h> // for GetTime, GetTimeMillis
+#include <util/time.h> // for GetTime
 #include <util/translation.h> // for bilingual_str
 #include <node/blockstorage.h> // for CleanupBlockRevFiles, fHavePruned, fReindex
 #include <node/context.h> // for NodeContext
@@ -43,7 +43,6 @@ bool LoadChainstate(bool& fLoaded,
     };
 
     do {
-        const auto load_block_index_start_time{SteadyClock::now()};
         try {
             LOCK(cs_main);
 
@@ -315,7 +314,6 @@ bool LoadChainstate(bool& fLoaded,
 
         if (!failed_verification) {
             fLoaded = true;
-            LogPrintf(" block index %15dms\n", Ticks<std::chrono::milliseconds>(SteadyClock::now() - load_block_index_start_time));
         }
     } while(false);
     return true;