Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECH DEBT]: Reuse defaults of WorkspaceConfig in WorkspaceInstaller._prompt_for_new_installation #2698

Open
1 task done
JCZuurmond opened this issue Sep 23, 2024 · 0 comments · May be fixed by #3825
Open
1 task done

[TECH DEBT]: Reuse defaults of WorkspaceConfig in WorkspaceInstaller._prompt_for_new_installation #2698

JCZuurmond opened this issue Sep 23, 2024 · 0 comments · May be fixed by #3825
Assignees
@HariGS-DB
Labels
tech debt chores and design flaws

Comments

@JCZuurmond
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

The defaults for WorkspaceConfig are duplicated in WorkspaceInstaller._prompt_for_new_installation use the defaults in WorkspaceConfig instead

Proposed Solution

default_config = WorkspaceConfig(default_database)
...
prompts(<question>, default=default_config.<attribute>)  # Instead of hardcoding the default

Additional Context

No response
@JCZuurmond JCZuurmond added enhancement New feature or request needs-triage labels Sep 23, 2024
@JCZuurmond JCZuurmond added this to UCX Sep 23, 2024
@github-project-automation github-project-automation bot moved this to Triage in UCX Sep 23, 2024
JCZuurmond added a commit that referenced this issue Sep 23, 2024
@JCZuurmond
Go back to hardcoded workspace config defaults

Verified

This commit was signed with the committer’s verified signature.
JCZuurmond Cor
GPG key ID: A85FD0A1244EFC78
Verified
Learn about vigilant mode
2651484 
#2698 to solve this later
JCZuurmond added a commit that referenced this issue Sep 23, 2024
@JCZuurmond
Go back to hardcoded workspace config defaults

Verified

This commit was signed with the committer’s verified signature.
JCZuurmond Cor
GPG key ID: A85FD0A1244EFC78
Verified
Learn about vigilant mode
6387616 
#2698 to solve this later
JCZuurmond added a commit that referenced this issue Sep 24, 2024
@JCZuurmond
Go back to hardcoded workspace config defaults

Verified

This commit was signed with the committer’s verified signature.
JCZuurmond Cor
GPG key ID: A85FD0A1244EFC78
Verified
Learn about vigilant mode
bb2b5c1 
#2698 to solve this later
JCZuurmond added a commit that referenced this issue Sep 24, 2024
@JCZuurmond
Go back to hardcoded workspace config defaults

Verified

This commit was signed with the committer’s verified signature.
JCZuurmond Cor
GPG key ID: A85FD0A1244EFC78
Verified
Learn about vigilant mode
a5114a3 
#2698 to solve this later
JCZuurmond added a commit that referenced this issue Sep 25, 2024
@JCZuurmond
Go back to hardcoded workspace config defaults

Verified

This commit was signed with the committer’s verified signature.
JCZuurmond Cor
GPG key ID: A85FD0A1244EFC78
Verified
Learn about vigilant mode
f77802d 
#2698 to solve this later
@nfx nfx added tech debt chores and design flaws and removed enhancement New feature or request needs-triage labels Oct 9, 2024
@nfx nfx moved this from Triage to Quarter Backlog in UCX Oct 9, 2024
@HariGS-DB HariGS-DB linked a pull request Mar 8, 2025 that will close this issue
Open
1 task
@HariGS-DB HariGS-DB self-assigned this Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HariGS-DB HariGS-DB

Labels
tech debt chores and design flaws
Projects
UCX
Status: No status
Milestone
No milestone
3 participants
@nfx @JCZuurmond @HariGS-DB