Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Angular 6: Upgrade to RxJS 6 #63

Closed
MickL opened this issue Apr 30, 2018 · 5 comments
Closed

Support Angular 6: Upgrade to RxJS 6 #63

MickL opened this issue Apr 30, 2018 · 5 comments

Comments

@MickL
Copy link

MickL commented Apr 30, 2018

Currently ngx-logger is not working with Angular 6 at all
RxJS 5.x -> 6.x migration guide: https://github.com/ReactiveX/rxjs/blob/master/MIGRATION.md

@dbfannin
Copy link
Owner

@MickL, We have a PR to upgrade the logger angular6. Since it's still in release candidate, we're waiting for the actual 6 release to merge in that pr #59.

Until then, you can npm install rxjs-compat on your application and it will make rxjs6 backwards compatible. I'm running a few angular 6 apps using the current version of the logger this way without issues.

I hope this helps!

@MickL
Copy link
Author

MickL commented Apr 30, 2018

Thanks for the quick response! Shouldnt we merge it and create an RC or alpha for ngx-logger, too? I don't think much will change on use of RxJS 6 since it is stable. That way we can start using (and testing!) it right now without use of rxjs-compat

@dbfannin
Copy link
Owner

@MickL, let me check with the guy who is working on that PR and make sure it's in a stable state. If it is, I'll try to get a pre-release version out there for you.

@dbfannin
Copy link
Owner

@MickL, ngx-logger3.0.0-rc1 has been published. please let us know if you run into any issues using it! thanks!

@JavierFuentes
Copy link

Sorry, but I have this issue with this release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants