From 4d62f65b3f06744a1a9493be5e9446fbfcd8c582 Mon Sep 17 00:00:00 2001 From: Gordon Woodhull Date: Fri, 18 Sep 2015 08:02:16 -0400 Subject: [PATCH] more specific test for filter function for #990 @esjewett, I think this is a slightly safer way to check for a custom filter function such as those in dc.filters --- src/base-mixin.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/base-mixin.js b/src/base-mixin.js index 4d65dd69e..666b00357 100644 --- a/src/base-mixin.js +++ b/src/base-mixin.js @@ -71,7 +71,8 @@ dc.baseMixin = function (_chart) { var _filterHandler = function (dimension, filters) { if (filters.length === 0) { dimension.filter(null); - } else if (filters.length === 1 && !Array.isArray(filters[0])) { + } else if (filters.length === 1 && !filters[0].isFiltered) { + // single value and not a function-based filter dimension.filterExact(filters[0]); } else { dimension.filterFunction(function (d) {