Sunburst : filtered elements should be animated

[Frozenlock]

Filtered elements instantaneously disappear without animation.

See the Sunburst example.

Without animation, it's not immediately clear what is being removed from the chart.

The pie chart calls dc.transition which is missing for the sunburst chart.
Could it be as simple as that?

Pie chart : https://github.com/dc-js/dc.js/blob/develop/src/pie-chart.js#L124
Sunburst : https://github.com/dc-js/dc.js/blob/develop/src/sunburst-chart.js#L128

[gordonwoodhull]

I'm not seeing any transitions at all on the sunburst chart, except for the labels. Are you seeing the same?

Pie/sunburst slice transitions are really difficult, first because you have to do custom tweens, and second because it's not always clear where a slice is disappearing to or appearing from. You'll notice a lot of funny behaviors in the pie chart.

The line you're pointing at is only the transition for the position of the whole chart. That will help only when the size or position of the chart changes.

[ialarmedalien]

There are various bugs in the code that are stopping the transitions from being performed—the main problem is that the existing code talks about x, dx, y, and dy, which are from the d3 v3 era, but v4/v5 uses x0, x1, y0, and y1. I am working on a branch that fixes those errors and adds some new functionality to the sunburst chart.

[gordonwoodhull]

Thanks @ialarmedalien!

Please let us know how it goes. Even a partial solution would be a big help.

[Frozenlock]

Appears to be fixed in the last version.
Thank you very much!

[gordonwoodhull]

Yes @ialarmedalien fixed it in #1481 for 3.0.7