From f39971f4e0d51cbc35d4903f563f3a42697a460e Mon Sep 17 00:00:00 2001 From: the3ver Date: Fri, 25 May 2018 08:31:01 +0200 Subject: [PATCH] fix "TypeError: scale.ticks is undefined" Fix "TypeError: scale.ticks is undefined" when setting .renderHorizontalGridLines(true) on charts with ordinal y scale, see #539 --- src/coordinate-grid-mixin.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/coordinate-grid-mixin.js b/src/coordinate-grid-mixin.js index f34ba1474..4ca3c092c 100644 --- a/src/coordinate-grid-mixin.js +++ b/src/coordinate-grid-mixin.js @@ -695,8 +695,8 @@ dc.coordinateGridMixin = function (_chart) { var gridLineG = g.select('g.' + HORIZONTAL_CLASS); if (_renderHorizontalGridLine) { - // Last part copied from https://github.com/d3/d3-axis/blob/master/src/axis.js#L48 - var ticks = axis.tickValues() ? axis.tickValues() : scale.ticks.apply(scale, axis.tickArguments()); + // see https://github.com/d3/d3-axis/blob/master/src/axis.js#L48 + var ticks = axis.tickValues() ? axis.tickValues() : (scale.ticks ? scale.ticks.apply(scale, axis.tickArguments()) : scale.domain()); if (gridLineG.empty()) { gridLineG = g.insert('g', ':first-child')