Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run sanity-check without BATCH_SIZE gets stuck #498

Closed
cazala opened this issue Oct 1, 2018 · 1 comment
Closed

npm run sanity-check without BATCH_SIZE gets stuck #498

cazala opened this issue Oct 1, 2018 · 1 comment
Labels

Comments

@cazala
Copy link
Contributor

cazala commented Oct 1, 2018

➜  marketplace git:(feat/updateop) npm run sanity-check -- --self-heal
[main] Batch size configurable via BATCH_SIZE
[main] Connecting to database
[main] Connecting to Ethereum node
[main] Starting CLI
[Sanity] [1/3]: Running Parcel
[asyncBatch] 45300.5 as batch size, got undefined

i dunno why [asyncBatch] 45300.5 as batch size, got undefined but it stays there forever.

It only works as BATCH_SIZE=XXX npm run sanity-check -- --self-heal

We need a default value or make it throw if not provided or something

@cazala cazala added the bug label Oct 1, 2018
@nicosantangelo
Copy link
Contributor

The default is half the total size! that's why you see 45300.5. It's a generic approach intended for smaller arrays.

I'll add a more sensible default (max between half the total size and 100) and I'll replace [asyncBatch] 45300.5 as batch size, got undefined with [asyncBatch] Defaulting to 100 as batch size, got undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants