Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Version Sorting in Snippets #172

Closed
stanbrub opened this issue Sep 22, 2023 · 1 comment · Fixed by #317
Closed

Improve Version Sorting in Snippets #172

stanbrub opened this issue Sep 22, 2023 · 1 comment · Fixed by #317
Assignees
Labels
enhancement New feature or request

Comments

@stanbrub
Copy link
Collaborator

stanbrub commented Sep 22, 2023

Versions for Deephaven look like 0.28.0, 0.28.1, etc. That style is not lexicographical sort-able. For some queries used for generating tables using the Benchmark snippets, sorting by version is important. Sorting by timestamp is not reliable, because it's possible that a re-run of a specific release will be needed, which would put the timestamps out of order.

  • Write a function to convert version to something sortable
  • Add it inline for the version column being sorted (since benchmark data is small, this should not affect performance)
  • The converted result need not be a string
  • Related to Platform Collection of Deephaven Build Number/Date #228
@stanbrub stanbrub added the enhancement New feature or request label Sep 22, 2023
@stanbrub stanbrub linked a pull request Jul 12, 2024 that will close this issue
@stanbrub stanbrub self-assigned this Jul 12, 2024
@stanbrub
Copy link
Collaborator Author

This ticket has been fulfilled by approaching the problem a different way. With the change in directory structure, all "set" level directory labels, whether version or date, are lexicographical sort-able. These are used to sort newest to oldest, Timestamp is no longer a factor in the benchmark queries. For example, concerning the nightly category, "last 5 days" means "last 5 sets". Concerning the release category, "last 5 versions" means "last 5 sets".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant