Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish and advertise minimum required docker version #769

Closed
devinrsmith opened this issue Jun 22, 2021 · 3 comments
Closed

Establish and advertise minimum required docker version #769

devinrsmith opened this issue Jun 22, 2021 · 3 comments
Assignees
Labels
docker documentation Improvements or additions to documentation
Milestone

Comments

@devinrsmith
Copy link
Member

We had a developer run into issues, where their docker engine complained about multistage builds. They were running on Centos 7, which uses a relatively old docker version 1.13.1 (note: docker versions changed from 1.13.x -> 17.x). Multistage builds were released on for 17.05, so at the very least, we need 17.05 to build. Technically, or practically, we may want to require a newer version.

There may also be docker-compose compatibility we want to advertise. (Note: an old docker-compose won't effect the building of images, just the running.)

@devinrsmith devinrsmith added documentation Improvements or additions to documentation docker labels Jun 22, 2021
@devinrsmith devinrsmith added this to the June 2021 milestone Jun 22, 2021
@devinrsmith devinrsmith changed the title Establish and adverise minimum required docker version Establish and advertise minimum required docker version Jun 22, 2021
@chipkent chipkent assigned hythloda and unassigned chipkent Jul 16, 2021
@devinrsmith
Copy link
Member Author

It would be good to further break this down into requirements for building and requirements for running.

@hythloda
Copy link
Contributor

DO NOT USE:
Docker Engine Version: 1.12.6
Docker Engine Version: 1.13.1
Docker Engine Version: 17.03.0-ce
Execution failed for task ':deephaven-jpy:buildDockerForRuntime'.

BUILDS BUT DOES NOT RUN:
Docker Engine Version: 18.09.*
Docker Engine Version: 19.03.*
Execution failed for task ':grpc-proxy:buildDocker'.
Need to change alpine to version 3.12
vi grpc-proxy/Dockerfile
FROM docker.io/library/alpine:3.12

DOES NOT RUN:
docker-compose version 1.24.1
Unsupported config option for services.envoy: 'extends'
So far tested runs with:
docker-compose version 1.29.2
more docker-compose tests later

@pete-petey pete-petey modified the milestones: June 2021, Aug 2021 Aug 25, 2021
@pete-petey pete-petey modified the milestones: Aug 2021, Sept 2021 Sep 13, 2021
@chipkent
Copy link
Member

Resolved in #1207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants