Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience types for DynamicTableWriter #793

Closed
jjbrosnan opened this issue Jun 28, 2021 · 0 comments
Closed

Add convenience types for DynamicTableWriter #793

jjbrosnan opened this issue Jun 28, 2021 · 0 comments
Assignees
Labels
feature request New feature or request triage
Milestone

Comments

@jjbrosnan
Copy link
Contributor

jjbrosnan commented Jun 28, 2021

Using DynamicTableWriter requires an import of the following:

"io.deephaven.db.v2.utils.DynamicTableWriter"

Also, in Python, when telling DynamicTableWriter what types to expect for each column, they require the types from deephaven.jpy:

tableWriter = DynamicTableWriter(["Column1", "Column2", "Column3"], [jpy.get_type("int"), jpy.get_type("java.lang.String"), jpy.get_type(...)])

Doing this feels clunky. The user experience could use improvement. For instance, in Python, I'd like to not have to call jpy.get_type() for each column. The code would get ugly fast if you want to use a DynamicTableWriter to create a ticking table with more than just a few columns. Adding convenience types there would greatly increase code readability.

@jjbrosnan jjbrosnan added feature request New feature or request triage labels Jun 28, 2021
@jjbrosnan jjbrosnan self-assigned this Jul 23, 2021
@jjbrosnan jjbrosnan added this to the July 2021 milestone Jul 23, 2021
@pete-petey pete-petey modified the milestones: July 2021, Aug 2021 Aug 25, 2021
@pete-petey pete-petey modified the milestones: Aug 2021, Sept 2021 Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request triage
Projects
None yet
Development

No branches or pull requests

2 participants