Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of PowerShell installer #218

Closed
MarkTiedemann opened this issue Jun 21, 2022 · 0 comments · Fixed by #219
Closed

Improve performance of PowerShell installer #218

MarkTiedemann opened this issue Jun 21, 2022 · 0 comments · Fixed by #219

Comments

@MarkTiedemann
Copy link
Contributor

On my machine, install.ps1 is ~7x faster if I switch from Invoke-WebRequest to curl.exe and from Expand-Archive to tar.exe.

Before:

PS C:\dev\deno_install> measure-command { .\install.ps1 } | select -expand totalseconds
13,1810087

After:

PS C:\dev\deno_install> measure-command { .\install.ps1 } | select -expand totalseconds
1,8624925

This is similar to what's mentioned in #154:

As brought up in #153, since early 2018, curl and tar are available on Windows 10 by default. Thus, on a modern Windows 10 installation, curl could be used to download files and tar could be used to extract a .zip file.

The new implementation would look like this:

curl.exe -Lo $DenoZip $DenoUri

tar.exe xf $DenoZip -C $BinDir

If this proposal would be accepted, #216 could be closed.

@MarkTiedemann MarkTiedemann changed the title Improve performance of Powershell installer Improve performance of PowerShell installer Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant