formatOnSave & autocomplete became slower after update with Deno 1.37.0

[ynwd]

Describe the bug

• formatOnSave and autocomplete became slower after update with Deno 1.37.0
• this did not happen in previous versions

what actually happened?

Operating System

• Mac

[ynwd]

For a temporary solution, use esbenp.prettier-vscode again.

{
  "deno.enable": true,
  "deno.lint": true,
  "deno.codeLens.test": true,
  "editor.formatOnSave": true,
  "deno.importMap": "import_map.json",
  "editor.defaultFormatter": "esbenp.prettier-vscode",
  "[typescriptreact]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "[typescript]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "[javascriptreact]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "[javascript]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "[css]": {
    "editor.defaultFormatter": "vscode.css-language-features"
  }
}

[bartlomieju]

CC @nayeemrmn can you take a look?

[ynwd]

For a temporary solution, use esbenp.prettier-vscode again.

{
  "deno.enable": true,
  "deno.lint": true,
  "deno.codeLens.test": true,
  "editor.formatOnSave": true,
  "deno.importMap": "import_map.json",
  "editor.defaultFormatter": "esbenp.prettier-vscode",
  "[typescriptreact]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "[typescript]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "[javascriptreact]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "[javascript]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "[css]": {
    "editor.defaultFormatter": "vscode.css-language-features"
  }
}

It not works, btw.

So i downgrade to 1.36.4 -- and the problem is gone.

@bartlomieju @nayeemrmn

[nayeemrmn]

@ynwd If the problem is still there when changing the default formatter, it's not the formatter that's slow. Is it just the LSP in general being unresponsive? I can't see anything like that. Can you give a more detailed reproduction e.g. a sample file in a new project?

[ynwd]

@ynwd If the problem is still there when changing the default formatter, it's not the formatter that's slow. Is it just the LSP in general being unresponsive? I can't see anything like that. Can you give a more detailed reproduction e.g. a sample file in a new project?

@nayeemrmn
very strange. after re-downloading 1.37.0, the problem went away. I will reopen this issue if the problem occurs again. Thank You.

[nayeemrmn]

@ynwd Looks like this is the same as denoland/deno#20136. Watch that issue for updates.

[ynwd]

on a very small project (like hello world http server), this problem is not found.

but when I switch to the bigger one (with watch mode and a complex import_map -- fullstack apps), this problem is found again.

so my temporary solution is back to use previous version (v1.36.4)

[nayeemrmn]

Closing in favour of #943. Thanks for reporting