Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct the dates on the map #137

Closed
mattstratton opened this issue Apr 14, 2016 · 7 comments · Fixed by #1457
Closed

correct the dates on the map #137

mattstratton opened this issue Apr 14, 2016 · 7 comments · Fixed by #1457
Assignees

Comments

@mattstratton
Copy link
Member

As mentioned in #55:

 dates are showing as "YYYY-MM-DD" vs. the existing site showing "mmm DD"

If someone wants to take this on, that's cool. I don't think it's a showstopper right now.

@davidasnider
Copy link
Contributor

PR #155 submitted for date formatting

@bridgetkromhout bridgetkromhout changed the title Dates on map do not match current site correct the dates on the map May 2, 2016
@bridgetkromhout
Copy link
Collaborator

This was somewhat fixed but only has start dates now. Could use end dates.

@bridgetkromhout
Copy link
Collaborator

Related to #882 - needs startdate math as well as end dates.

@bridgetkromhout
Copy link
Collaborator

Let's say Scenario 1 is to leave this as-is, which looks like this:

screen shot 2016-11-19 at 10 33 27 pm

We've been living without both start and end dates on the map, but the problem with not showing the end date is it assumes people know these are two-day events (which maybe we should not assume).

If we want to change it, it's trivial to fix https://github.com/devopsdays/devopsdays-web/blob/master/themes/devopsdays-responsive/layouts/partials/map.html#L26:

-          ['{{ .city}}', {{ .coordinates | safeJS }}, '{{ dateFormat "Jan 2" .startdate }}', '/events/{{ .name }}'],
+          ['{{ .city}}', {{ .coordinates | safeJS }}, '{{ dateFormat "Jan 2" .startdate }}-{{ dateFormat "2" .enddate }}', '/events/{{ .name }}'],

But this is assuming we want it to look somewhat more like it did in the webby days. The down side is that single-day events (like Moscow) and events that span a month barrier (Minneapolis in this test) would look strange; let's call this Scenario 2:

screen shot 2016-11-19 at 10 29 18 pm

Alternatively, if we keep the full month formatting, it would look like Scenario 3 here:

screen shot 2016-11-19 at 10 24 42 pm

@mattstratton, do you have a preference?

@mattstratton
Copy link
Member Author

I would go for scenario 4, which is:

  1. if one day event, show only the one date
  2. if spans a month barrier, show both months
  3. if neither 1 or 2, show month only once.

Since this is all being opened up in the redesign, I think it's fine to tackle the right way.

@mattstratton
Copy link
Member Author

The reason I say this, is in the redesign the dates of the events are displayed on the front page not only on the map element; so we need to solve for this anyway.

@bridgetkromhout
Copy link
Collaborator

Okay, here's what Scenario 4 looks like (with fake dates for Warsaw, as a demonstration). PR in flight - merge if this is what you wanted.

screen shot 2016-11-20 at 6 08 54 pm

@ghost ghost assigned mattstratton Nov 21, 2016
@ghost ghost removed the needs review label Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants