Merge pull request #2239 from digitalfabrik/pylint-tests

Disable some pylint warnings in tests

Author: timobrembeck

integreat_cms/integreat-cms-cli

@@ -1,5 +1,4 @@
 #!/usr/bin/env python3
-# pylint: disable=invalid-name
 """ Django's command-line utility for administrative tasks. """
 import configparser
 import os

pyproject.toml

@@ -86,6 +86,7 @@ dev = [
     "pyjwt",
     "pylint",
     "pylint-django",
+    "pylint-per-file-ignores",
     "pytest-circleci-parallelized",
     "pytest-cov",
     "pytest-django",
@@ -251,6 +252,7 @@ dev-pinned = [
     "PyJWT==2.6.0",
     "pylint==2.17.2",
     "pylint-django==2.5.3",
+    "pylint-per-file-ignores==1.2.0",
     "pylint-plugin-utils==0.7",
     "pyproject_hooks==1.0.0",
     "pytest==7.2.2",
@@ -340,6 +342,7 @@ order_by_type = false
 jobs = 0
 load-plugins = [
     "pylint_django",
+    "pylint_per_file_ignores",
     "pylint.extensions.code_style",
     "pylint.extensions.comparetozero",
     "pylint.extensions.comparison_placement",
@@ -387,3 +390,6 @@ enable = [
 
 [tool.pylint.reports]
 output-format = "colorized"
+
+[tool.pylint-per-file-ignores]
+"/tests/"="unused-argument,missing-function-docstring"

tests/api/test_api_feedback.py

@@ -34,7 +34,6 @@
 }
 
 
-# pylint: disable=unused-argument
 @pytest.mark.django_db
 @pytest.mark.parametrize("view_name,post_data", API_FEEDBACK_VIEWS)
 def test_api_feedback_success(load_test_data, view_name, post_data):
@@ -82,7 +81,6 @@ def test_api_feedback_success(load_test_data, view_name, post_data):
     assert feedback.region_id == 1
 
 
-# pylint: disable=unused-argument
 @pytest.mark.django_db
 @pytest.mark.parametrize(
     "view_name,kwargs,post_data,response_data", API_FEEDBACK_ERRORS
@@ -118,7 +116,6 @@ def test_api_feedback_errors(
     assert not Feedback.objects.exists()
 
 
-# pylint: disable=unused-argument
 @pytest.mark.django_db
 def test_api_feedback_invalid_method(load_test_data):
     """

tests/api/test_api_push_page.py

@@ -5,7 +5,6 @@
 from integreat_cms.cms.models import Page
 
 
-# pylint: disable=unused-argument
 @pytest.mark.django_db
 def test_api_push_page_content(load_test_data):
     """

tests/api/test_api_result.py

@@ -6,7 +6,6 @@
 from .api_config import API_ENDPOINTS
 
 
-# pylint: disable=unused-argument
 @pytest.mark.django_db
 @pytest.mark.parametrize(
     "endpoint,wp_endpoint,expected_result,expected_code,expected_queries", API_ENDPOINTS

tests/cms/models/events/test_recurrence_rule.py

@@ -8,7 +8,6 @@
 from integreat_cms.cms.models import Event, RecurrenceRule
 
 
-# pylint: disable=missing-function-docstring
 class TestCreatingIcalRule:
     """
     Test whether to_ical_rrule_string function is calculating the rrule correctly

tests/cms/test_duplicate_regions.py

@@ -9,7 +9,7 @@
 from integreat_cms.cms.utils.linkcheck_utils import get_url_count
 
 
-# pylint: disable=unused-argument,too-many-locals
+# pylint: disable=too-many-locals
 @pytest.mark.order("last")
 @pytest.mark.django_db(transaction=True, serialized_rollback=True)
 def test_duplicate_regions(load_test_data_transactional, admin_client):

tests/cms/test_login.py

@@ -3,7 +3,6 @@
 from django.urls import reverse
 
 
-# pylint: disable=unused-argument
 @pytest.mark.django_db
 @pytest.mark.parametrize(
     "username", ["root", "[email protected]", "management", "[email protected]"]
@@ -46,7 +45,6 @@ def test_login_success(load_test_data, client, settings, username):
         )
 
 
-# pylint: disable=unused-argument
 @pytest.mark.django_db
 @pytest.mark.parametrize(
     "username",

tests/cms/test_page_filters.py

@@ -4,7 +4,6 @@
 from django.urls import reverse
 
 
-# pylint: disable=unused-argument
 @pytest.mark.django_db
 def test_page_filters(load_test_data, admin_client):
     """

tests/cms/views/status_code/test_view_status_code_1.py

@@ -4,7 +4,6 @@
 from ..view_config import PARAMETRIZED_VIEWS
 
 
-# pylint: disable=missing-function-docstring
 @pytest.mark.django_db
 @pytest.mark.parametrize("view_name,kwargs,post_data,roles", PARAMETRIZED_VIEWS[1::16])
 def test_view_status_code_1(login_role_user, view_name, kwargs, post_data, roles):

tests/cms/views/status_code/test_view_status_code_10.py

@@ -4,7 +4,6 @@
 from ..view_config import PARAMETRIZED_VIEWS
 
 
-# pylint: disable=missing-function-docstring
 @pytest.mark.django_db
 @pytest.mark.parametrize("view_name,kwargs,post_data,roles", PARAMETRIZED_VIEWS[10::16])
 def test_view_status_code_10(login_role_user, view_name, kwargs, post_data, roles):

tests/cms/views/status_code/test_view_status_code_11.py

@@ -4,7 +4,6 @@
 from ..view_config import PARAMETRIZED_VIEWS
 
 
-# pylint: disable=missing-function-docstring
 @pytest.mark.django_db
 @pytest.mark.parametrize("view_name,kwargs,post_data,roles", PARAMETRIZED_VIEWS[11::16])
 def test_view_status_code_11(login_role_user, view_name, kwargs, post_data, roles):

tests/cms/views/status_code/test_view_status_code_12.py

@@ -4,7 +4,6 @@
 from ..view_config import PARAMETRIZED_VIEWS
 
 
-# pylint: disable=missing-function-docstring
 @pytest.mark.django_db
 @pytest.mark.parametrize("view_name,kwargs,post_data,roles", PARAMETRIZED_VIEWS[12::16])
 def test_view_status_code_12(login_role_user, view_name, kwargs, post_data, roles):

tests/cms/views/status_code/test_view_status_code_13.py

@@ -4,7 +4,6 @@
 from ..view_config import PARAMETRIZED_VIEWS
 
 
-# pylint: disable=missing-function-docstring
 @pytest.mark.django_db
 @pytest.mark.parametrize("view_name,kwargs,post_data,roles", PARAMETRIZED_VIEWS[13::16])
 def test_view_status_code_13(login_role_user, view_name, kwargs, post_data, roles):

tests/cms/views/status_code/test_view_status_code_14.py

@@ -4,7 +4,6 @@
 from ..view_config import PARAMETRIZED_VIEWS
 
 
-# pylint: disable=missing-function-docstring
 @pytest.mark.django_db
 @pytest.mark.parametrize("view_name,kwargs,post_data,roles", PARAMETRIZED_VIEWS[14::16])
 def test_view_status_code_14(login_role_user, view_name, kwargs, post_data, roles):

tests/cms/views/status_code/test_view_status_code_15.py

@@ -4,7 +4,6 @@
 from ..view_config import PARAMETRIZED_VIEWS
 
 
-# pylint: disable=missing-function-docstring
 @pytest.mark.django_db
 @pytest.mark.parametrize("view_name,kwargs,post_data,roles", PARAMETRIZED_VIEWS[15::16])
 def test_view_status_code_15(login_role_user, view_name, kwargs, post_data, roles):

tests/cms/views/status_code/test_view_status_code_16.py

@@ -4,7 +4,6 @@
 from ..view_config import PARAMETRIZED_VIEWS
 
 
-# pylint: disable=missing-function-docstring
 @pytest.mark.django_db
 @pytest.mark.parametrize("view_name,kwargs,post_data,roles", PARAMETRIZED_VIEWS[0::16])
 def test_view_status_code_16(login_role_user, view_name, kwargs, post_data, roles):

tests/cms/views/status_code/test_view_status_code_2.py

@@ -4,7 +4,6 @@
 from ..view_config import PARAMETRIZED_VIEWS
 
 
-# pylint: disable=missing-function-docstring
 @pytest.mark.django_db
 @pytest.mark.parametrize("view_name,kwargs,post_data,roles", PARAMETRIZED_VIEWS[2::16])
 def test_view_status_code_2(login_role_user, view_name, kwargs, post_data, roles):

tests/cms/views/status_code/test_view_status_code_3.py

@@ -4,7 +4,6 @@
 from ..view_config import PARAMETRIZED_VIEWS
 
 
-# pylint: disable=missing-function-docstring
 @pytest.mark.django_db
 @pytest.mark.parametrize("view_name,kwargs,post_data,roles", PARAMETRIZED_VIEWS[3::16])
 def test_view_status_code_3(login_role_user, view_name, kwargs, post_data, roles):

tests/cms/views/status_code/test_view_status_code_4.py

@@ -4,7 +4,6 @@
 from ..view_config import PARAMETRIZED_VIEWS
 
 
-# pylint: disable=missing-function-docstring
 @pytest.mark.django_db
 @pytest.mark.parametrize("view_name,kwargs,post_data,roles", PARAMETRIZED_VIEWS[4::16])
 def test_view_status_code_4(login_role_user, view_name, kwargs, post_data, roles):

tests/cms/views/status_code/test_view_status_code_5.py

@@ -4,7 +4,6 @@
 from ..view_config import PARAMETRIZED_VIEWS
 
 
-# pylint: disable=missing-function-docstring
 @pytest.mark.django_db
 @pytest.mark.parametrize("view_name,kwargs,post_data,roles", PARAMETRIZED_VIEWS[5::16])
 def test_view_status_code_5(login_role_user, view_name, kwargs, post_data, roles):

tests/cms/views/status_code/test_view_status_code_6.py

@@ -4,7 +4,6 @@
 from ..view_config import PARAMETRIZED_VIEWS
 
 
-# pylint: disable=missing-function-docstring
 @pytest.mark.django_db
 @pytest.mark.parametrize("view_name,kwargs,post_data,roles", PARAMETRIZED_VIEWS[6::16])
 def test_view_status_code_6(login_role_user, view_name, kwargs, post_data, roles):

tests/cms/views/status_code/test_view_status_code_7.py

@@ -4,7 +4,6 @@
 from ..view_config import PARAMETRIZED_VIEWS
 
 
-# pylint: disable=missing-function-docstring
 @pytest.mark.django_db
 @pytest.mark.parametrize("view_name,kwargs,post_data,roles", PARAMETRIZED_VIEWS[7::16])
 def test_view_status_code_7(login_role_user, view_name, kwargs, post_data, roles):

tests/cms/views/status_code/test_view_status_code_8.py

@@ -4,7 +4,6 @@
 from ..view_config import PARAMETRIZED_VIEWS
 
 
-# pylint: disable=missing-function-docstring
 @pytest.mark.django_db
 @pytest.mark.parametrize("view_name,kwargs,post_data,roles", PARAMETRIZED_VIEWS[8::16])
 def test_view_status_code_8(login_role_user, view_name, kwargs, post_data, roles):

tests/cms/views/status_code/test_view_status_code_9.py

@@ -4,7 +4,6 @@
 from ..view_config import PARAMETRIZED_VIEWS
 
 
-# pylint: disable=missing-function-docstring
 @pytest.mark.django_db
 @pytest.mark.parametrize("view_name,kwargs,post_data,roles", PARAMETRIZED_VIEWS[9::16])
 def test_view_status_code_9(login_role_user, view_name, kwargs, post_data, roles):

tests/cms/views/test_public_view_status_code.py

@@ -5,7 +5,6 @@
 from .view_config import PARAMETRIZED_PUBLIC_VIEWS
 
 
-# pylint: disable=unused-argument
 @pytest.mark.django_db
 @pytest.mark.parametrize("view_name,post_data", PARAMETRIZED_PUBLIC_VIEWS)
 def test_public_view_status_code(load_test_data, view_name, post_data):

tests/conftest.py

@@ -42,7 +42,6 @@
 pytest_plugins = "aiohttp.pytest_plugin"
 
 
-# pylint: disable=unused-argument
 @pytest.fixture(scope="session")
 def load_test_data(django_db_setup, django_db_blocker):
     """
@@ -58,7 +57,6 @@ def load_test_data(django_db_setup, django_db_blocker):
         call_command("loaddata", "integreat_cms/cms/fixtures/test_data.json")
 
 
-# pylint: disable=unused-argument
 @pytest.fixture(scope="function")
 def load_test_data_transactional(transactional_db, django_db_blocker):
     """
@@ -75,7 +73,7 @@ def load_test_data_transactional(transactional_db, django_db_blocker):
         call_command("loaddata", "integreat_cms/cms/fixtures/test_data.json")
 
 
-# pylint: disable=unused-argument,redefined-outer-name
+# pylint: disable=redefined-outer-name
 @pytest.fixture(scope="session", params=ALL_ROLES)
 def login_role_user(request, load_test_data, django_db_blocker):
     """
@@ -102,7 +100,7 @@ def login_role_user(request, load_test_data, django_db_blocker):
     return client, request.param
 
 
-# pylint: disable=unused-argument,redefined-outer-name
+# pylint: disable=redefined-outer-name
 @pytest.fixture(scope="session", params=ALL_ROLES)
 def login_role_user_async(request, load_test_data, django_db_blocker):
     """

tests/core/management/commands/test_duplicate_pages.py

@@ -39,7 +39,6 @@ def test_duplicate_pages_non_existing_region(settings):
     assert str(exc_info.value) == 'Region with slug "non-existing" does not exist.'
 
 
-# pylint: disable=unused-argument
 @pytest.mark.django_db
 def test_duplicate_pages(settings, load_test_data):
     """

tests/core/management/commands/test_find_missing_versions.py

@@ -27,7 +27,6 @@ def test_find_missing_versions_invalid_model():
     )
 
 
-# pylint: disable=unused-argument
 @pytest.mark.django_db
 @pytest.mark.parametrize("model", ["page", "event", "poi"])
 def test_find_missing_versions_success(load_test_data, model):
@@ -39,7 +38,6 @@ def test_find_missing_versions_success(load_test_data, model):
     assert not err
 
 
-# pylint: disable=unused-argument
 @pytest.mark.django_db
 def test_find_missing_versions_failure(load_test_data):
     """

tests/core/management/commands/test_replace_links.py

@@ -27,7 +27,6 @@ def test_replace_links_missing_replace():
     assert str(exc_info.value) == "Error: the following arguments are required: replace"
 
 
-# pylint: disable=unused-argument
 @pytest.mark.django_db
 def test_replace_links_non_existing_region(load_test_data):
     """
@@ -45,7 +44,6 @@ def test_replace_links_non_existing_region(load_test_data):
     assert str(exc_info.value) == 'Region with slug "non-existing" does not exist.'
 
 
-# pylint: disable=unused-argument
 @pytest.mark.django_db
 def test_replace_links_non_existing_username(load_test_data):
     """
@@ -63,7 +61,6 @@ def test_replace_links_non_existing_username(load_test_data):
     assert str(exc_info.value) == 'User with username "non-existing" does not exist.'
 
 
-# pylint: disable=unused-argument
 @pytest.mark.order("last")
 @pytest.mark.django_db(transaction=True, serialized_rollback=True)
 def test_replace_links_dry_run(load_test_data_transactional):
@@ -111,7 +108,6 @@ def test_replace_links_dry_run(load_test_data_transactional):
     ).exists(), "Replaced link should not be created during dry run"
 
 
-# pylint: disable=unused-argument
 @pytest.mark.order("last")
 @pytest.mark.django_db(transaction=True, serialized_rollback=True)
 def test_replace_links_commit(load_test_data_transactional):

tests/core/management/commands/test_reset_deepl_budget.py

@@ -40,7 +40,6 @@ def test_not_first_day():
         )
 
 
-# pylint: disable=unused-argument
 @pytest.mark.order("last")
 @pytest.mark.django_db(transaction=True, serialized_rollback=True)
 def test_reset_deepl_budget(load_test_data_transactional):

tests/core/management/commands/test_summ_ai_bulk.py

@@ -29,7 +29,6 @@ def test_summ_ai_bulk_missing_username():
     )
 
 
-# pylint: disable=unused-argument
 @pytest.mark.django_db
 def test_summ_ai_bulk_disabled(settings, load_test_data):
     """
@@ -51,7 +50,7 @@ def test_summ_ai_bulk_non_existing_region():
     assert str(exc_info.value) == 'Region with slug "non-existing" does not exist.'
 
 
-# pylint: disable=unused-argument,fixme
+# pylint: disable=fixme
 @pytest.mark.django_db
 def test_summ_ai_bulk_disabled_region(load_test_data):
     """
@@ -64,7 +63,6 @@ def test_summ_ai_bulk_disabled_region(load_test_data):
     # assert str(exc_info.value) == 'SUMM.AI API is disabled in "Stadt Augsburg".'
 
 
-# pylint: disable=unused-argument
 @pytest.mark.django_db
 def test_summ_ai_bulk_non_existing_username(load_test_data):
     """