Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple API tests #1023

Closed
Tracked by #765
timobrembeck opened this issue Nov 20, 2021 · 0 comments · Fixed by #1095
Closed
Tracked by #765

Simple API tests #1023

timobrembeck opened this issue Nov 20, 2021 · 0 comments · Fixed by #1095
Assignees
Labels
feature New feature or request prio: medium Should be scheduled in the forseeable future.

Comments

@timobrembeck
Copy link
Member

Motivation

At the moment, we postponed all "real" testing to the Version 1.2 milestone (see #765).
However, before we release the CMS in production, we should have at least a few basic API tests since this is the most critical part of the system and the it's not possible to use the apps when our API isn't working properly.

Proposed Solution

For our test data, define the expected JSON result for each API endpoint and add unit tests to check whether they're equivalent.
If the test data set is missing some models (which means that the API endpoint would return an empty result), add some dummy data to the test data before defining the expected result.

Alternatives

Additional Context

While you're at it, you could also review our basic view-tests in integreat_cms/cms/tests/views and check whether there are any views which can be added without much effort (e.g. because they don't expect custom GET/POST params).

@timobrembeck timobrembeck added feature New feature or request prio: medium Should be scheduled in the forseeable future. labels Nov 20, 2021
@timobrembeck timobrembeck added this to the Version 1.0 milestone Nov 20, 2021
@JoeyStk JoeyStk assigned melegiul and unassigned JoeyStk Jan 5, 2022
@timobrembeck timobrembeck mentioned this issue Nov 3, 2022
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request prio: medium Should be scheduled in the forseeable future.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants