-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do useInterval
and useTimeout
re-initialize on every re-render?
#9
Comments
Well, given a recent article from Dan Abramov I think the current hooks need to be updated in order to be performant. |
@dispix when you say "the current hooks" do you mean the hooks in this repo or the React hooks API? It would be great to have some kind of notice or warning on the repo. Otherwise it seems like the repo is actively maintained, as the last change was about 2 months ago. |
The version |
You're right, two months is a long time. I've found your repo through one of the "awesome-react-hooks" repos and at first thought it's maintained, since it's there. Then I figured that Don't maintain the repo because of me. I've copy-pasted most of the hooks to my own repo. |
Nooooo, this repo's awesome! Can't force you to maintain it but I'd be happy to help if it makes a difference. I think it'll get more attention as people start to adopt hooks more. |
@skipjack Well honestly I'm really glad you think so 😃 I mean if at least one person likes it then I'd be glad to maintain it ! But your help would be welcome of course. |
Lol I appreciate that but I'm fully aware how time consuming open source can be, so don't maintain just for my sake. I guess my point is just give it some time, I think this package will get more traction. I came across it through I'll stop spamming @vfonic's issue though, just saw the conversation above and figured I'd chime in with an upvote. |
I'm not sure if something changed in the API for
useEffect
, but I think that, if you omit the second argument, it will re-run the effect on every re-render.The text was updated successfully, but these errors were encountered: