Failing tests for #1487

Author: cristi-contiu

tests/Generator/DiffGeneratorTest.php

@@ -180,6 +180,61 @@ public function testGenerateFromEmptySchema(): void
         self::assertSame('path2', $this->migrationDiffGenerator->generate('2345', null, false, 120, true, true));
     }
 
+    public function testGenerateCallsComparatorWithExpectedSchemasWhenDbalHasSchemaAssetsFilter(): void
+    {
+        // a standard Regex SchemaAssetsFilter already registered on the DBAL
+        $dbalSchemaAssetsFilter = static function ($assetName): bool {
+            return (bool) preg_match('~^some_schema\.~', $assetName);
+        };
+
+        $fromSchema = new Schema();
+
+        $toTable1 = new Table('some_schema.table1');
+        $toTable2 = new Table('some_schema.table2');
+        $toSchema = new Schema([$toTable1, $toTable2]);
+
+        $this->schemaManager->expects(self::once())
+            ->method('introspectSchema')
+            ->willReturn($fromSchema);
+
+        $this->schemaProvider->expects(self::once())
+            ->method('createSchema')
+            ->willReturn($toSchema);
+
+        $this->dbalConfiguration->expects(self::once())
+            ->method('getSchemaAssetsFilter')
+            ->willReturn($dbalSchemaAssetsFilter);
+
+        $comparator = $this->createMock(Comparator::class);
+        $matcher = self::exactly(2);
+        $comparator->expects($matcher)
+            ->method('compareSchemas')
+            ->willReturnCallback(
+                function (Schema $oldSchema, Schema $newSchema) use ($matcher, $toTable1, $toTable2): SchemaDiff {
+                    // assert that comparator is called with the expected schema
+                    if ($matcher->numberOfInvocations() === 1) { // up
+                        self::assertEquals([$toTable1, $toTable2], $newSchema->getTables());
+                    }
+
+                    if ($matcher->numberOfInvocations() === 2) { // down
+                        self::assertEquals([$toTable1, $toTable2], $oldSchema->getTables());
+                    }
+
+                    return self::createStub(SchemaDiff::class);
+                }
+            );
+
+        $this->schemaManager->expects(self::once())
+            ->method('createComparator')
+            ->willReturn($comparator);
+
+        $this->migrationSqlGenerator->expects(self::exactly(2))
+            ->method('generate')
+            ->willReturnOnConsecutiveCalls('up', 'down');
+
+        $this->migrationDiffGenerator->generate('Version1234', null);
+    }
+
     protected function setUp(): void
     {
         $this->dbalConfiguration      = $this->createMock(DBALConfiguration::class);