Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate C# formatting implications of new #line pragmas #54469

Closed
NTaylorMullen opened this issue Jun 29, 2021 · 4 comments
Closed

Investigate C# formatting implications of new #line pragmas #54469

NTaylorMullen opened this issue Jun 29, 2021 · 4 comments

Comments

@NTaylorMullen
Copy link
Contributor

In C# 10 we're working on Improved #line pragmas. Pre-existing line pragmas influence tooling in many different facets. One of which we've noticed in generated files is at format time what happens?

With the enhanced line pragmas being created we may need to update our C# formatting engine to better understand the new form of line pragmas to ensure things don't break down.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 29, 2021
@jcouv
Copy link
Member

jcouv commented Jul 2, 2021

Linking to test plan for new #line feature: #54509

@jinujoseph jinujoseph added Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 9, 2021
@jinujoseph jinujoseph added this to the 17.0 milestone Jul 9, 2021
@jcouv
Copy link
Member

jcouv commented Jul 9, 2021

Chatted with Taylor to confirm expectations for this issue.
Some background: Two editors (one is projection-based if flag pictured below is disabled, one is new editor in dev17.0p2). New code generation (using new #line directives) will be worked on by Safia in dev17.0p3.

Will coordinate with Safia to do some validation and route any issues we find then (depending on whether compiler, IDE or Razor problem) then.

MicrosoftTeams-image

@jcouv
Copy link
Member

jcouv commented Aug 11, 2021

@NTaylorMullen Can we close this issue now?

@NTaylorMullen
Copy link
Contributor Author

@NTaylorMullen Can we close this issue now?

Yup!

@jcouv jcouv closed this as completed Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants