VM #define Sleep macros break GC

[sdmaclea]

In various places, the VM introduces #define Sleep(a) Dont_Use_Sleep(a). These are troublesome for the GC which has to introduce a workaround.

Per @jkotas "this hack made sense for full .NET Framework. It is not really valuable for CoreCLR. I would rather delete all the code to #define Sleep to prevent people from using it."

My tip has these #define for Sleep in headers...

src/gc/gc.h:// This is a funny workaround for the fact that "common.h" defines Sleep to be
src/gc/gc.h:// However, GCToOSInterface defines a function called Sleep, which (due to this define) becomes
src/inc/clrhost.h:#define Sleep(dwMilliseconds) \
src/vm/comsynchronizable.h:#define Sleep(a) Dont_Use_Sleep(a)
src/vm/ecalllist.h:#define Sleep(a) Dont_Use_Sleep(a)

[mangod9]

@sdmaclea this appears to be fixed, or is this still a concern?

[sdmaclea]

Looks like it is still a concern.

~/git/runtime$ git grep '#define *Sleep' origin/master
origin/master:src/coreclr/src/vm/comsynchronizable.cpp:#define Sleep(dwMilliseconds) Dont_Use_Sleep(dwMilliseconds)
origin/master:src/coreclr/src/vm/comsynchronizable.h:#define Sleep(a) Dont_Use_Sleep(a)
origin/master:src/coreclr/src/vm/ecalllist.h:#define Sleep(a) Dont_Use_Sleep(a)
origin/master:src/coreclr/src/vm/hosting.cpp:#define SleepEx(dwMilliseconds,bAlertable) \
origin/master:src/coreclr/src/vm/threads.cpp:#define Sleep(a) Dont_Use_Sleep(a)
origin/master:src/coreclr/src/vm/threadsuspend.cpp:#define Sleep(a) Dont_Use_Sleep(a)
origin/master:src/coreclr/src/vm/win32threadpool.cpp:#define SleepEx(a,b) Dont_Use_SleepEx(a,b)
origin/master:src/coreclr/src/vm/win32threadpool.cpp:                #define SleepEx(a,b) Dont_Use_SleepEx(a,b)
origin/master:src/coreclr/src/vm/win32threadpool.cpp:#define SleepEx(a,b) Dont_Use_SleepEx(a,b)

[mangod9]

I meant I didnt see the workaround you mention in gc.h. Perhaps it should be moved to vm area then?

[sdmaclea]

Done