Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Assertion failed '!"Missing flags on tree"' during 'Assertion prop' for recently added RuntimeHelpers.CreateSpan uses #80632

Closed
jakobbotsch opened this issue Jan 13, 2023 · 4 comments
Closed

JIT: Assertion failed '!"Missing flags on tree"' during 'Assertion prop' for recently added RuntimeHelpers.CreateSpan uses #80632

jakobbotsch opened this issue Jan 13, 2023 · 4 comments
Assignees
@EgorBo
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs
Milestone
8.0.0

Comments

@jakobbotsch
Copy link
Member

jakobbotsch commented Jan 13, 2023 •
edited
Loading

libraries-jitstress jobs are failing with this assert, e.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=136796&view=ms.vss-test-web.build-test-results-tab&runId=2975122&resultId=191688&paneView=debug.

From bisection I think it is not exposed by a JIT change and we are hitting it now after #79461 (I bisected with an SPMI context, and even old JITs hit the assert).

Attached a win-x64 SPMI context that hits it on recent JIT commits (e.g. 3f5210d).

fail-39322.zip
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 13, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jan 13, 2023
@ghost
Copy link

ghost commented Jan 13, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

libraries-jitstress jobs are failing with this assert, e.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=136796&view=ms.vss-test-web.build-test-results-tab&runId=2975122&resultId=191688&paneView=debug.

From bisection I think it is not exposed by a JIT change and we are hitting it now after #79461 (I bisected with an SPMI context, and even old JITs hit the assert).

Attached an SPMI context that hits it on recent JIT commits (e.g. 3f5210d).

fail-39322.zip

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@jakobbotsch jakobbotsch changed the title JIT: Assertion failed '!"Missing flags on tree"' during 'Assertion prop' JIT: Assertion failed '!"Missing flags on tree"' during 'Assertion prop' for recently added RuntimeHelpers.CreateSpan uses Jan 13, 2023
@jakobbotsch jakobbotsch added blocking-clean-ci-optional Blocking optional rolling runs and removed untriaged New issue has not been triaged by the area owner labels Jan 13, 2023
@jakobbotsch jakobbotsch added this to the 8.0.0 milestone Jan 13, 2023
@jakobbotsch jakobbotsch mentioned this issue Jan 13, 2023
Merged
@EgorBo EgorBo self-assigned this Jan 13, 2023
@SingleAccretion
Copy link
Contributor

Probably #80622 will fix this by virtue of using a non-CONST handle for this data.

@jakobbotsch
Copy link
Member Author

@EgorBo Can you double check with the attached SPMI context?

@runfoapp runfoapp bot mentioned this issue Jan 13, 2023
Closed
@EgorBo
Copy link
Member

EgorBo commented Jan 14, 2023

Just checked, the assert is gone with the patch. @jakobbotsch thanks for the SPMI context it saved an hour or two🙂

@EgorBo EgorBo closed this as completed Jan 14, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
3 participants
@EgorBo @jakobbotsch @SingleAccretion