Merge pull request #8081 from SimonCropp/remove-redundant-private-set

remove redundant private set

Author: v-wuzhai

src/Microsoft.TemplateEngine.Abstractions/Installer/InstallRequest.cs

@@ -41,12 +41,12 @@ public InstallRequest(string identifier, string? version = null, string? install
         /// <remarks>
         /// Could be folder name, NuGet PackageId, path to .nupkg...
         /// </remarks>
-        public string PackageIdentifier { get; private set; }
+        public string PackageIdentifier { get; }
 
         /// <summary>
         /// Specific version to be installed or null to install latest.
         /// </summary>
-        public string? Version { get; private set; }
+        public string? Version { get; }
 
         /// <summary>
         /// Additional details, like NuGet Server(Source), that specific installer uses.

src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/Macros/EvaluateMacroConfig.cs

@@ -25,7 +25,7 @@ internal EvaluateMacroConfig(string variableName, string? dataType, string condi
             }
         }
 
-        internal string Condition { get; private set; }
+        internal string Condition { get; }
 
         internal ConditionStringEvaluator Evaluator { get; private set; } = EvaluatorSelector.SelectStringEvaluator(DefaultEvaluator);
 

src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/Macros/JoinMacroConfig.cs

@@ -71,7 +71,7 @@ internal enum JoinType
             Ref
         }
 
-        internal IReadOnlyList<(JoinType Type, string Value)> Symbols { get; private set; }
+        internal IReadOnlyList<(JoinType Type, string Value)> Symbols { get; }
 
         internal string Separator { get; private set; }
 

src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/Macros/RegexMacroConfig.cs

@@ -59,7 +59,7 @@ internal RegexMacroConfig(RegexMacro macro, IGeneratedSymbolConfig generatedSymb
             Steps = steps;
         }
 
-        internal string Source { get; private set; }
+        internal string Source { get; }
 
         internal IReadOnlyList<(string Regex, string Replacement)> Steps { get; private set; }
 

src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/Macros/SwitchMacroConfig.cs

@@ -54,7 +54,7 @@ internal SwitchMacroConfig(SwitchMacro macro, IGeneratedSymbolConfig generatedSy
 
         internal ConditionStringEvaluator Evaluator { get; private set; } = EvaluatorSelector.SelectStringEvaluator(DefaultEvaluator);
 
-        internal IReadOnlyList<(string? Condition, string Value)> Cases { get; private set; }
+        internal IReadOnlyList<(string? Condition, string Value)> Cases { get; }
 
         public void ResolveSymbolDependencies(IReadOnlyList<string> symbols)
         {

src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/ParameterBasedVariableCollection.cs

@@ -27,7 +27,7 @@ public ParameterBasedVariableCollection(
             : base(parent, values)
             => ParameterSetData = parameterSetData;
 
-        public IParameterSetData ParameterSetData { get; private set; }
+        public IParameterSetData ParameterSetData { get; }
 
         public static ParameterBasedVariableCollection Root(IParameterSetData parameterSetData) =>
             new(null, new Dictionary<string, object>(), parameterSetData);

src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/PostAction.cs

@@ -25,7 +25,7 @@ public PostAction(string? description, string? manualInstructions, Guid actionId
 
         public Guid ActionId { get; }
 
-        public bool ContinueOnError { get; private set; }
+        public bool ContinueOnError { get; }
 
         public IReadOnlyDictionary<string, string> Args { get; } = new Dictionary<string, string>();
 

src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/VariableConfig.cs

@@ -19,13 +19,13 @@ private VariableConfig(
             Expand = expand;
         }
 
-        public IReadOnlyDictionary<string, string> Sources { get; private init; }
+        public IReadOnlyDictionary<string, string> Sources { get; }
 
-        public IReadOnlyList<string> Order { get; private init; }
+        public IReadOnlyList<string> Order { get; }
 
-        public string? FallbackFormat { get; private init; }
+        public string? FallbackFormat { get; }
 
-        public bool Expand { get; private init; }
+        public bool Expand { get; }
 
         internal static IVariableConfig Default { get; } =
                 new VariableConfig(

src/Microsoft.TemplateEngine.Utils/ListExtensions.cs

@@ -47,14 +47,14 @@ public static class ListExtensions
             return allGrouped;
         }
 
-        private struct ValueWrapper<T>
+        private readonly struct ValueWrapper<T>
         {
             public ValueWrapper(T val)
             {
                 Val = val;
             }
 
-            public T Val { get; private set; }
+            public T Val { get; }
 
 #pragma warning disable IDE0251 // Make member 'readonly'
             public override bool Equals(object obj)

src/Microsoft.TemplateEngine.Utils/MultiValueParameter.cs

@@ -30,7 +30,7 @@ public MultiValueParameter(IReadOnlyList<string> values)
         /// <summary>
         /// The actual atomic values specified for the parameter.
         /// </summary>
-        public IReadOnlyList<string> Values { get; private init; }
+        public IReadOnlyList<string> Values { get; }
 
         public static bool TryPerformMultiValueEqual(object x, object y, out bool result)
         {

test/Microsoft.TemplateEngine.Orchestrator.RunnableProjects.UnitTests/BindSymbolTests.cs

@@ -707,7 +707,7 @@ public TestBindSymbolSource(Guid guid, string prefix = "test", bool requiresPref
 
             public int Priority => 0;
 
-            public Guid Id { get; private set; }
+            public Guid Id { get; }
 
             public bool RequiresPrefixMatch { get; }
 

tools/Microsoft.TemplateEngine.Authoring.TemplateVerifier/ScrubbersDefinition.cs

@@ -18,11 +18,11 @@ private ScrubbersDefinition() { }
 
     public delegate void ScrubFileByPath(string relativeFilePath, StringBuilder content);
 
-    internal Dictionary<string, Action<StringBuilder>> ScrubbersByExtension { get; private set; } = new Dictionary<string, Action<StringBuilder>>();
+    internal Dictionary<string, Action<StringBuilder>> ScrubbersByExtension { get; } = new Dictionary<string, Action<StringBuilder>>();
 
     internal Action<StringBuilder>? GeneralScrubber { get; private set; }
 
-    internal List<ScrubFileByPath> ByPathScrubbers { get; private set; } = new List<ScrubFileByPath>();
+    internal List<ScrubFileByPath> ByPathScrubbers { get; } = new List<ScrubFileByPath>();
 
     public ScrubbersDefinition AddScrubber(Action<StringBuilder> scrubber, string? extension = null)
     {

tools/Microsoft.TemplateSearch.TemplateDiscovery/NuGet/NugetPackProvider.cs

@@ -51,7 +51,7 @@ internal NuGetPackProvider(string name, string query, DirectoryInfo packageTempB
             }
         }
 
-        public string Name { get; private set; }
+        public string Name { get; }
 
         public bool SupportsGetPackageInfoViaApi => true;
 

tools/Microsoft.TemplateSearch.TemplateDiscovery/NuGet/NugetPackageSearchResult.cs

@@ -10,7 +10,7 @@ internal class NuGetPackageSearchResult
     {
         internal int TotalHits { get; private set; }
 
-        internal List<NuGetPackageSourceInfo> Data { get; private set; } = new List<NuGetPackageSourceInfo>();
+        internal List<NuGetPackageSourceInfo> Data { get; } = new List<NuGetPackageSourceInfo>();
 
         //property names are explained here: https://docs.microsoft.com/en-us/nuget/api/search-query-service-resource
         internal static NuGetPackageSearchResult FromJObject(JObject entry)

tools/Microsoft.TemplateSearch.TemplateDiscovery/NuGet/NugetPackageSourceInfo.cs

@@ -25,9 +25,9 @@ internal NuGetPackageSourceInfo(string id, string version)
             Version = version;
         }
 
-        public string Name { get; private set; }
+        public string Name { get; }
 
-        public string Version { get; private set; }
+        public string Version { get; }
 
         public long TotalDownloads { get; private set; }
 

tools/Microsoft.TemplateSearch.TemplateDiscovery/PackChecking/DownloadedPackInfo.cs

@@ -24,7 +24,7 @@ internal DownloadedPackInfo(ITemplatePackageInfo info, string filePath)
 
         public string? Version => _info.Version;
 
-        public string Path { get; private set; }
+        public string Path { get; }
 
         public long TotalDownloads => _info.TotalDownloads;
 

tools/Microsoft.TemplateSearch.TemplateDiscovery/PackChecking/FilteredPackageInfo.cs

@@ -47,10 +47,10 @@ private FilteredPackageInfo(string name, string reason)
         public bool Reserved { get; private set; }
 
         [JsonIgnore]
-        public string? Description { get; private set; }
+        public string? Description { get; }
 
         [JsonIgnore]
-        public string? IconUrl { get; private set; }
+        public string? IconUrl { get; }
     }
 }
 

tools/Microsoft.TemplateSearch.TemplateDiscovery/Results/LegacyBlobTemplateInfo.cs

@@ -103,7 +103,7 @@ public LegacyBlobTemplateInfo(ITemplateInfo templateInfo)
         public string Name { get; private set; }
 
         [JsonIgnore]
-        public bool PreferDefaultName { get; private set; }
+        public bool PreferDefaultName { get; }
 
         [JsonProperty]
         public string ShortName
@@ -160,10 +160,10 @@ public string ShortName
         public DateTime? ConfigTimestampUtc { get; private set; }
 
         [JsonIgnore]
-        public IReadOnlyDictionary<string, string> TagsCollection { get; private set; }
+        public IReadOnlyDictionary<string, string> TagsCollection { get; }
 
         [JsonIgnore]
-        public IParameterDefinitionSet ParameterDefinitions { get; private set; }
+        public IParameterDefinitionSet ParameterDefinitions { get; }
 
         [JsonIgnore]
         [Obsolete("Use ParameterDefinitionSet instead.")]
@@ -179,7 +179,7 @@ public string ShortName
         public IReadOnlyDictionary<string, ICacheParameter> CacheParameters { get; private set; } = new Dictionary<string, ICacheParameter>();
 
         [JsonIgnore]
-        public IReadOnlyList<Guid> PostActions { get; private set; }
+        public IReadOnlyList<Guid> PostActions { get; }
 
         [JsonIgnore]
         IReadOnlyList<TemplateConstraintInfo> ITemplateMetadata.Constraints => throw new NotImplementedException();