Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vitest ^2 to peerDependencies of @fast-check/vitest #5114

Closed
IanVS opened this issue Jul 9, 2024 · 5 comments
Closed

Add vitest ^2 to peerDependencies of @fast-check/vitest #5114

IanVS opened this issue Jul 9, 2024 · 5 comments

Comments

@IanVS
Copy link

IanVS commented Jul 9, 2024

🚀 Feature Request

Support vitest 2.x in peerDependencies.

Motivation

I get a peer dependency warning when using vitest 2.0.1.

Vitest 2 and @fast-check/vitest are working fine in my current project, FWIW.

@TomerAberbach
Copy link
Contributor

Funny, came here to say the same thing!

@dubzzz
Copy link
Owner

dubzzz commented Jul 11, 2024

I was working on it recently on #5108. It should be there soon

@dubzzz
Copy link
Owner

dubzzz commented Jul 12, 2024

It seems that Vitest v2 broke part of fast-check. The broken part is around stack overflows at shrink time. While there is probably nothing to worry about, I may issue separately the bump and the peer-dep change. So far to unlock users, I'll just bump the peer stuff.

@IanVS
Copy link
Author

IanVS commented Jul 12, 2024

Interesting. That sounds like a good plan. FWIW I'm using vitest 2 with fast-check right now and haven't noticed any problems so far.

@dubzzz
Copy link
Owner

dubzzz commented Jul 12, 2024

Published at 0.1.2. I succeed into bumping without fixing anything in fast-check, it was mostly a side-effect of a change on their side but the impact is null for fast-check's users.

@dubzzz dubzzz closed this as completed Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants