Skip to content

Commit 6002ee7

Browse files
authored
fix(jsonld): add missing ODRL mapping in ContractAgreement (#4517)
* fix(jsonld): add missing ODRL mapping in ContractAgreement * chore: deps file
1 parent ded228d commit 6002ee7

File tree

4 files changed

+16
-8
lines changed

4 files changed

+16
-8
lines changed

DEPENDENCIES

-4
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,15 @@ maven/mavencentral/com.fasterxml.jackson.core/jackson-annotations/2.14.0, Apache
1717
maven/mavencentral/com.fasterxml.jackson.core/jackson-annotations/2.14.1, Apache-2.0, approved, #5303
1818
maven/mavencentral/com.fasterxml.jackson.core/jackson-annotations/2.16.2, Apache-2.0, approved, #11606
1919
maven/mavencentral/com.fasterxml.jackson.core/jackson-annotations/2.17.1, Apache-2.0, approved, #13672
20-
maven/mavencentral/com.fasterxml.jackson.core/jackson-annotations/2.17.2, Apache-2.0, approved, #13672
2120
maven/mavencentral/com.fasterxml.jackson.core/jackson-annotations/2.18.0, Apache-2.0, approved, #16364
2221
maven/mavencentral/com.fasterxml.jackson.core/jackson-core/2.14.1, Apache-2.0 AND MIT, approved, #4303
2322
maven/mavencentral/com.fasterxml.jackson.core/jackson-core/2.16.2, Apache-2.0 AND MIT, approved, #11602
24-
maven/mavencentral/com.fasterxml.jackson.core/jackson-core/2.17.2, Apache-2.0 AND MIT, approved, #13665
2523
maven/mavencentral/com.fasterxml.jackson.core/jackson-core/2.18.0, Apache-2.0 AND MIT, approved, #16371
2624
maven/mavencentral/com.fasterxml.jackson.core/jackson-databind/2.11.0, Apache-2.0, approved, CQ23093
2725
maven/mavencentral/com.fasterxml.jackson.core/jackson-databind/2.14.0, Apache-2.0, approved, #4105
2826
maven/mavencentral/com.fasterxml.jackson.core/jackson-databind/2.14.1, Apache-2.0, approved, #15232
2927
maven/mavencentral/com.fasterxml.jackson.core/jackson-databind/2.16.2, Apache-2.0, approved, #11605
3028
maven/mavencentral/com.fasterxml.jackson.core/jackson-databind/2.17.1, Apache-2.0, approved, #13671
31-
maven/mavencentral/com.fasterxml.jackson.core/jackson-databind/2.17.2, Apache-2.0, approved, #13671
3229
maven/mavencentral/com.fasterxml.jackson.core/jackson-databind/2.18.0, Apache-2.0, approved, #16372
3330
maven/mavencentral/com.fasterxml.jackson.dataformat/jackson-dataformat-yaml/2.14.0, Apache-2.0, approved, #5933
3431
maven/mavencentral/com.fasterxml.jackson.dataformat/jackson-dataformat-yaml/2.16.2, Apache-2.0, approved, #11855
@@ -43,7 +40,6 @@ maven/mavencentral/com.fasterxml.jackson.jakarta.rs/jackson-jakarta-rs-json-prov
4340
maven/mavencentral/com.fasterxml.jackson.module/jackson-module-jakarta-xmlbind-annotations/2.17.1, Apache-2.0, approved, #13668
4441
maven/mavencentral/com.fasterxml.jackson.module/jackson-module-jakarta-xmlbind-annotations/2.18.0, Apache-2.0, approved, #16368
4542
maven/mavencentral/com.fasterxml.jackson/jackson-bom/2.16.2, Apache-2.0, approved, #11852
46-
maven/mavencentral/com.fasterxml.jackson/jackson-bom/2.17.2, Apache-2.0, approved, #14162
4743
maven/mavencentral/com.fasterxml.jackson/jackson-bom/2.18.0, , restricted, clearlydefined
4844
maven/mavencentral/com.fasterxml.uuid/java-uuid-generator/4.1.0, Apache-2.0, approved, clearlydefined
4945
maven/mavencentral/com.github.cliftonlabs/json-simple/3.0.2, Apache-2.0, approved, clearlydefined

extensions/common/json-ld/src/main/resources/document/management-context-v1.jsonld

+10-2
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,15 @@
4040
"CallbackAddress": "edc:CallbackAddress",
4141
"NegotiationState": "edc:NegotiationState",
4242
"TerminateNegotiation": "edc:TerminateNegotiation",
43-
"ContractAgreement": "edc:ContractAgreement",
43+
"ContractAgreement": {
44+
"@id": "edc:ContractAgreement",
45+
"@context": {
46+
"@import": "http://www.w3.org/ns/odrl.jsonld",
47+
"@propagate": true,
48+
"uid": null,
49+
"type": null
50+
}
51+
},
4452
"TransferRequest": "edc:TransferRequest",
4553
"TransferState": "edc:TransferState",
4654
"TransferProcess": {
@@ -187,4 +195,4 @@
187195
"@container": "@set"
188196
}
189197
}
190-
}
198+
}

system-tests/management-api/management-api-test-runner/src/test/java/org/eclipse/edc/test/e2e/managementapi/SerdeEndToEndTest.java

+4-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,10 @@ void ser_ContractAgreement() {
106106
assertThat(compactResult.getString("providerId")).isEqualTo(agreement.getProviderId());
107107
assertThat(compactResult.getString("consumerId")).isEqualTo(agreement.getConsumerId());
108108
assertThat(compactResult.getString("assetId")).isEqualTo(agreement.getAssetId());
109-
assertThat(compactResult.getJsonObject("policy")).isNotNull();
109+
assertThat(compactResult.getJsonObject("policy")).isNotNull()
110+
.satisfies(policy -> {
111+
assertThat(policy.get(TYPE)).isEqualTo(Json.createValue("Agreement"));
112+
});
110113
assertThat(compactResult.getJsonNumber("contractSigningDate")).isNotNull();
111114

112115
}

system-tests/management-api/management-api-test-runner/src/test/java/org/eclipse/edc/test/e2e/managementapi/TestFunctions.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import org.eclipse.edc.policy.model.AtomicConstraint;
3838
import org.eclipse.edc.policy.model.LiteralExpression;
3939
import org.eclipse.edc.policy.model.Policy;
40+
import org.eclipse.edc.policy.model.PolicyType;
4041
import org.eclipse.edc.policy.model.Rule;
4142
import org.eclipse.edc.spi.types.domain.DataAddress;
4243
import org.eclipse.edc.spi.types.domain.callback.CallbackAddress;
@@ -202,7 +203,7 @@ public static ContractAgreement createContractAgreement(String id) {
202203
.providerId("providerId")
203204
.consumerId("consumerId")
204205
.assetId("assetId")
205-
.policy(Policy.Builder.newInstance().build())
206+
.policy(Policy.Builder.newInstance().type(PolicyType.CONTRACT).build())
206207
.build();
207208
}
208209

0 commit comments

Comments
 (0)