Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown mechanism for recurring ExecutionPlan #295

Open
farhin23 opened this issue Feb 11, 2025 · 2 comments
Open

Shutdown mechanism for recurring ExecutionPlan #295

farhin23 opened this issue Feb 11, 2025 · 2 comments
Assignees
Labels
feature_request New feature request, awaiting triage good first issue Good for newcomers

Comments

@farhin23
Copy link

Feature Request

Implement mechanism to stop recurring task of ExecutionPlan and shutdown its executor service.

Which Areas Would Be Affected?

  • ExecutionPlan(and its implementation),
  • ExecutionManager and
  • FederatedCatalogCacheExtension

Why Is the Feature Desired?

When terminating a BaseRuntime that uses a recurring ExecutionPlan, it is essential to ensure that the associated executor service is properly shut down.
While the executor service threads will eventually terminate when the java process exits, relying solely on this behavior can lead to unnecessary resource consumption. The proposed mechanism can trigger and ensure a clean shutdown of these threads.

Who will sponsor this feature?

Please @-mention the committer that will sponsor your feature.

Solution Proposal

ExecutionPlan and ExecutionManager should include a stop method.
The FederatedCatalogCacheExtension should call the ExecutionManager#stop() during shutdown phase.

Originally posted by @farhin23 in #273

@farhin23 farhin23 added feature_request New feature request, awaiting triage triage all new issues awaiting classification labels Feb 11, 2025
@farhin23 farhin23 marked this as a duplicate of #272 Feb 11, 2025
@farhin23 farhin23 self-assigned this Feb 11, 2025
@ndr-brt ndr-brt removed the triage all new issues awaiting classification label Feb 12, 2025
Copy link

This issue is stale because it has been open for 28 days with no activity.

@github-actions github-actions bot added the stale label Mar 13, 2025
@ndr-brt ndr-brt removed the stale label Mar 13, 2025
@ndr-brt
Copy link
Member

ndr-brt commented Mar 13, 2025

@farhin23 are you still committed to this? otherwise it can be assigned to somebody else

@ndr-brt ndr-brt added the good first issue Good for newcomers label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature_request New feature request, awaiting triage good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants