Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theia welcome page shows after each restart #277

Closed
tsmaeder opened this issue Jul 11, 2023 · 4 comments
Closed

Theia welcome page shows after each restart #277

tsmaeder opened this issue Jul 11, 2023 · 4 comments

Comments

@tsmaeder
Copy link
Contributor

Bug Description:

The Theia welcome page (editor) is shown each time I start Blueprint. My expectation would be that the page only shows the first time or after an update has been installed.

Steps to Reproduce:

  1. Start Blueprint (you get the Welcome page)
  2. Quit Blueprint
  3. Start Blueprint (you get the Welcom page again.

Additional Information

  • Operating System: Windows
  • Theia Version: Blueprint 1.39.0
@tsmaeder
Copy link
Contributor Author

image

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Jul 12, 2023

@tsmaeder if you have the preference on (from the screenshot it looks to be "checked") then each start of the application will open the welcome page if no editor is opened. The same behavior can be identified in VS Code.


I do see a bug however in this use-case:

  1. start blueprint
  2. uncheck the preference ("blueprint.alwaysShowWelcomePage": false)
  3. close the application
  4. open the application
  5. the page re-opens - bug

@tsmaeder
Copy link
Contributor Author

Indeed, that fixes the problem. I wonder, though, why this is on by default. I noticed that there is a "Show Welcome Page after every start of the application" check box at the bottom of the welcome page. But t.b.h., I didn't read this far down, and the check box disappears when the editor is too small. IMO, the "don't nag me"-UI should be more prominent.

@tsmaeder
Copy link
Contributor Author

Since this works as designed, I'm closing this one in favor of a feature request: #280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants