Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theia File Icons Theme - Quick Pick Styling #10089

Closed
colin-grant-work opened this issue Sep 13, 2021 · 5 comments · Fixed by #10172
Closed

Theia File Icons Theme - Quick Pick Styling #10089

colin-grant-work opened this issue Sep 13, 2021 · 5 comments · Fixed by #10172
Labels
ui/ux issues related to user interface / user experience

Comments

@colin-grant-work
Copy link
Contributor

Bug Description:

Since #9864

In the Open recent workspace... file picker, the icons are partially cut off to the left of the text.

image

Steps to Reproduce:

  1. You must have some entries in your workspace history file. (Open some workspaces if you haven't or if you're using a temporary THEIA_CONFIG_DIR )
  2. Set your icon theme to File Icons (Theia)
  3. Use the open recent workspace command (File > Open recent workspace...)
  4. Observe that the icons are cut off

Additional Information

  • Operating System: RHEL7
  • Theia Version: master
@colin-grant-work
Copy link
Contributor Author

@msujew, if you're interested.

@msujew
Copy link
Member

msujew commented Sep 13, 2021

Sure, I'll take a look at that tomorrow 👍

@colin-grant-work colin-grant-work added the ui/ux issues related to user interface / user experience label Sep 13, 2021
@vince-fugnitto
Copy link
Member

Another annoying thing is having the separators for each entry (which is needed to add the last modified date).

@Alnyli07
Copy link

Alnyli07 commented Apr 27, 2022

@vince-fugnitto, @msujew It seems to be broken again.

Screen Shot 2022-04-27 at 16 03 54

Following css code block brokes alignment:

/*@theia/filesystem/src/browser/style/file-icons.css*/
.theia-file-icons-js {
    /*
    Here, the `line-height` ensures that FontAwesome and `file-icons-js` container has the same height.
    Ideally, it would be 1 em, but since we set the max height above (and other places too) with 0.8
    multiplier, we use 0.8 em here too.
     */
    line-height: 0.8em;
}

version: 1.24.0

@vince-fugnitto
Copy link
Member

@Alnyli07 it should be fixed on master thanks to #11029.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants