Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialog: fix 'new file' and 'new folder' dialog styling #12154

Closed
vince-fugnitto opened this issue Feb 7, 2023 · 1 comment · Fixed by #12158
Closed

dialog: fix 'new file' and 'new folder' dialog styling #12154

vince-fugnitto opened this issue Feb 7, 2023 · 1 comment · Fixed by #12158
Assignees
@nnacin
Labels
good first issue good first issues for new contributors help wanted issues meant to be picked up, require help

Comments

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Feb 7, 2023 •
edited
Loading

Bug Description:

There is a regression regarding the styling of the New File and New Folder dialogs in the framework:

Before:

image

After:

image

The additional padding of the initial implementation is clearer and does not compact the information.

Steps to Reproduce:

  1. start the example-browser application
  2. open a workspace if none is already opened
  3. perform new file and new folder and confirm the styling
@vince-fugnitto vince-fugnitto added help wanted issues meant to be picked up, require help good first issue good first issues for new contributors labels Feb 7, 2023
@nnacin
Copy link
Contributor

nnacin commented Feb 7, 2023

I will look into solving this issue

@nnacin nnacin mentioned this issue Feb 7, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nnacin nnacin

Labels
good first issue good first issues for new contributors help wanted issues meant to be picked up, require help
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX 12154: add margin between input and text nnacin/theia
2 participants
@nnacin @vince-fugnitto