Elasticsearch Invalid phase can only be cleared through downscale

[pebrc]

cloud-on-k8s/pkg/controller/elasticsearch/elasticsearch_controller.go

Lines 208 to 211 in 16180dd

	} else if !state.IsElasticsearchPhase(esv1.ElasticsearchResourceInvalid) {
	// Do not overwrite invalid phase
	state.UpdateWithPhase(esv1.ElasticsearchReadyPhase)
	}

The above gives special treatment to the invalid phase. That means that once it is set it will never be overwritten unless another non-ready phase is set. But invalid can be a transient state e.g. a license check request that temporary fails or an error in the podTemplate that has been fixed.

cloud-on-k8s/pkg/controller/elasticsearch/driver/driver.go

Lines 239 to 243 in adb6ea5

	if !e.SupportedDistribution {
	msg := "Unsupported Elasticsearch distribution"
	// unsupported distribution, let's update the phase to "invalid" and stop the reconciliation
	d.ReconcileState.
	UpdateWithPhase(esv1.ElasticsearchResourceInvalid).

Because we preserve other non-ready phases when we update the phase to ApplyingChanges the only way to clear this status is to scale down the cluster by at least one node or have a node shutdown stall during a rolling upgrade (which is unlikely)