Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'source' instead of 'inline' in ScriptFilter #190

Closed
sethmlarson opened this issue Apr 20, 2020 · 2 comments
Closed

Use 'source' instead of 'inline' in ScriptFilter #190

sethmlarson opened this issue Apr 20, 2020 · 2 comments
Labels
good first issue Good for newcomers help wanted Solution is fleshed out and ready to be worked on

Comments

@sethmlarson
Copy link
Contributor

Also would be good to explicitly pass in lang="painless" in all the places ScriptFilter is used in series.py
@sethmlarson sethmlarson added help wanted Solution is fleshed out and ready to be worked on good first issue Good for newcomers labels Apr 20, 2020
@sethmlarson
Copy link
Contributor Author

Related to #186, add both to PR.

@sethmlarson sethmlarson mentioned this issue Apr 20, 2020
Closed
@sethmlarson
Copy link
Contributor Author

Closed via #191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Solution is fleshed out and ready to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sethmlarson