Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedicated client nodes as an option for TransportClient sniffing #16244

Closed
ppf2 opened this issue Jan 26, 2016 · 5 comments
Closed

Add dedicated client nodes as an option for TransportClient sniffing #16244

ppf2 opened this issue Jan 26, 2016 · 5 comments

Comments

@ppf2
Copy link
Member

ppf2 commented Jan 26, 2016

Currently TransportClient's sniffing feature only adds data nodes to the list of available hosts. For clusters that have dedicated client nodes, it will be nice for the sniffing feature to be able to honor client nodes so that the reduce phase can occur on the dedicated client node machines.

@makeyang
Copy link
Contributor

pelase also consider gateway node

@javanna
Copy link
Member

javanna commented Jan 27, 2016

would you add client nodes and data nodes, or client nodes only if there's at least a certain number of them (how many?) ? Or did you mean to add an option to the transport client to control this? I think we should do here what the language clients do, not sure if they add client nodes to their internal list. @clintongormley can comment on this.

@clintongormley
Copy link
Contributor

The lang clients are inconsistent here. Really you want a number of options available, eg:

  • client nodes
  • data nodes
  • tribe nodes
  • nodes with a particular tag (or tags)

and you probably want to prefer eg client nodes but allow fallback to eg data nodes...

@clintongormley
Copy link
Contributor

Discussed in FiF - we should add an overridable method which allows the user to specify whether a sniffed node should be used or not. Currently we only sniff data notes, but the predicate should allow client nodes to be accepted too.

@martijnvg
Copy link
Member

Closing in favour of #21888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants