Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared toolbar - match button styles to Lens #97454

Closed
1 task done
ryankeairns opened this issue Apr 19, 2021 · 2 comments · Fixed by #98099
Closed
1 task done

Shared toolbar - match button styles to Lens #97454

ryankeairns opened this issue Apr 19, 2021 · 2 comments · Fixed by #98099
Assignees
@cqliu1 @andreadelrio
Labels
Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ryankeairns
Copy link
Contributor

As discussed, we would follow the lead of Lens with regards to the toolbar button design adjustments for Amsterdam (target 7.14).

As seen here, they are adding a border which the shared toolbar should also adopt: #97237

  • adds border to the toolbar buttons (so far they are only used in Lens, and all of these borders make sense:

Screenshot 2021-04-15 at 14 24 37
@ryankeairns ryankeairns added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Apr 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ryankeairns ryankeairns mentioned this issue Apr 19, 2021
Open
@ryankeairns
Copy link
Contributor Author

Side note: I've opened an EUI issue to discuss whether these should ultimately move to EUI, in the future: elastic/eui#4730

@andreadelrio andreadelrio self-assigned this Apr 22, 2021
@andreadelrio andreadelrio mentioned this issue Apr 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cqliu1 cqliu1

@andreadelrio andreadelrio

Labels
Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[K8] Small fixes andreadelrio/kibana
4 participants
@ryankeairns @cqliu1 @andreadelrio @elasticmachine