Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer, I want to create a new Video component to be used on pages. #40

Closed
3 tasks
Bowens20832 opened this issue May 23, 2023 · 3 comments · Fixed by #75
Closed
3 tasks

As a developer, I want to create a new Video component to be used on pages. #40

Bowens20832 opened this issue May 23, 2023 · 3 comments · Fixed by #75
Labels
status: in progress This topic is in development progress and will be included in the tagged version. type: enhancement New feature or request.

Comments

@Bowens20832
Copy link
Contributor

@Bowens20832 Bowens20832 added type: enhancement New feature or request. good first issue Good for newcomers help wanted Open for all. You do not need permission to work on these. version: 2.2 labels May 23, 2023
@Bowens20832
Copy link
Contributor Author

Build the component based on the Vercel example: https://github.com/vercel/next.js/tree/canary/examples/with-videojs

@Bowens20832
Copy link
Contributor Author

@Bowens20832 Bowens20832 added the status: in progress This topic is in development progress and will be included in the tagged version. label May 24, 2023
@Bowens20832
Copy link
Contributor Author

This feature is taking a little bit longer than I had anticipated. I am going to leave my progress on a branch and move this issue to version 2.3.

https://github.com/elegantframework/elegant-cli/tree/feature%2Fvideo-player

I left off with a basic Video.js component that had loaded a youtube video properly. I was in the process of making the args dynamic, and adding styles to the video component.

The version seems to be outdated, and when I try and move past Video.js v4, Storybook becomes broken :(

Follow these guides to finish the component:

https://github.com/vercel/next.js/blob/canary/examples/with-videojs/components/Player.tsx
https://videojs.com/getting-started/

Add SEO rich snippets:

https://github.com/garmeeh/next-seo#video-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in progress This topic is in development progress and will be included in the tagged version. type: enhancement New feature or request.
Projects
Status: Elegant - version 2.3
Development

Successfully merging a pull request may close this issue.

1 participant