Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error screens when we can't get a JWT token #3023

Open
robintown opened this issue Feb 24, 2025 · 0 comments · May be fixed by #3076
Open

Show error screens when we can't get a JWT token #3023

robintown opened this issue Feb 24, 2025 · 0 comments · May be fixed by #3076
Assignees
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@robintown
Copy link
Member

robintown commented Feb 24, 2025

The current behavior when we can't obtain a token from the JWT service (whether due to a connection failure or a configuration error) is to do nothing. The call will sit in an unconnected state forever. As long as we know we won't retry the JWT token fetch, we should bubble this error up to the user as an error screen.

It's going to become more important to get this done as soon as we try to lock down the JWT service to only allow creation of LiveKit rooms for users on the same homeserver deployment as the SFU. (https://github.com/element-hq/voip-internal/issues/294)

@robintown robintown added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Feb 24, 2025
@BillCarsonFr BillCarsonFr self-assigned this Mar 6, 2025
@BillCarsonFr BillCarsonFr linked a pull request Mar 14, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants