You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR matrix-org/matrix-react-sdk#10343 has added Percy tests to have them take snapshots of viewport to check whether a long string does not overflow something.
It turns out that they do not work as intended. The snapshots should be taken after scrolling to the bottom of the timeline, so that they can capture EventTiles with replies, etc.
Outcome
What did you expect?
The tests should take snapshots of all content of the viewport, not only the header and introduction of the room but also EventTiles below them.
The test should include a step to check whether elements which should be captured are visible on viewport before taking each snapshot.
What happened instead?
They took snapshots of a viewport which is supposed to be displayed to users initially.
Operating system
No response
Browser information
No response
URL for webapp
No response
Application version
No response
Homeserver
No response
Will you send logs?
No
The text was updated successfully, but these errors were encountered:
Steps to reproduce
This PR matrix-org/matrix-react-sdk#10343 has added Percy tests to have them take snapshots of viewport to check whether a long string does not overflow something.
It turns out that they do not work as intended. The snapshots should be taken after scrolling to the bottom of the timeline, so that they can capture
EventTile
s with replies, etc.Outcome
What did you expect?
The tests should take snapshots of all content of the viewport, not only the header and introduction of the room but also
EventTile
s below them.The test should include a step to check whether elements which should be captured are visible on viewport before taking each snapshot.
What happened instead?
They took snapshots of a viewport which is supposed to be displayed to users initially.
Operating system
No response
Browser information
No response
URL for webapp
No response
Application version
No response
Homeserver
No response
Will you send logs?
No
The text was updated successfully, but these errors were encountered: