Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Percy tests to have them take snapshots of all content of the viewport #24885

Closed
luixxiul opened this issue Mar 21, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#10420
Labels

Comments

@luixxiul
Copy link

luixxiul commented Mar 21, 2023

Steps to reproduce

This PR matrix-org/matrix-react-sdk#10343 has added Percy tests to have them take snapshots of viewport to check whether a long string does not overflow something.

It turns out that they do not work as intended. The snapshots should be taken after scrolling to the bottom of the timeline, so that they can capture EventTiles with replies, etc.

9e0003701d79ae0217eb29933028ab03c2d68bac029d666b755ee34899a859c8
39e9ed7efb7dc1dbfc651ad10cf236566e9e90fce7e5cbdca2650a021da9be30
ecc0cd8aa8b185f8e11a717bb1a61496f81be93d00e9ecc91b2a0980e4a8c7d5

Outcome

What did you expect?

The tests should take snapshots of all content of the viewport, not only the header and introduction of the room but also EventTiles below them.

The test should include a step to check whether elements which should be captured are visible on viewport before taking each snapshot.

What happened instead?

They took snapshots of a viewport which is supposed to be displayed to users initially.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant