Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Percy test User settings tab - Preferences and User settings tab - General no longer capture all of the setting flags on the tab #25391

Closed
luixxiul opened this issue May 17, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#10947
Closed

Percy test User settings tab - Preferences and User settings tab - General no longer capture all of the setting flags on the tab #25391

luixxiul opened this issue May 17, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#10947
Assignees
@kerryarchibald
Labels
A-Developer-Experience T-Task Tasks for the team like planning Z-Flaky-Test A test is raising false alarms

Comments

@luixxiul
Copy link

Steps to reproduce

  1. Check https://percy.io/dfde73bd/matrix-react-sdk/builds/27461110/changed/1527545851

Outcome

What did you expect?

mx_SettingsTab should be captured.

What happened instead?

The dialog was captured instead.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@luixxiul luixxiul changed the title Percy test User settings tab - Preferences no longer captures all of the setting flags on the tab Percy test User settings tab - Preferences and User settings tab - General no longer capture all of the setting flags on the tab May 18, 2023
@luixxiul
Copy link
Author

The same thing started to be observed for the General tab: https://matrix.to/#/!bEWtlqtDwCLFIAKAcv:matrix.org/$rr0aLusnMWWsEdvcRCZA9i6MNtXVKyOnlGlSdWBr7Ew?via=matrix.org&via=element.io&via=envs.net

@kerryarchibald kerryarchibald self-assigned this May 18, 2023
@kerryarchibald
Copy link
Contributor

cy.findByTestId and percySnapshotElement do not play together.
percySnapshotElement uses jquery element.selector as the scope. When chained with a cy.get this is a selector and works fine, but for findByTestId is eg findByTestId(<testid>)

@kerryarchibald kerryarchibald added T-Task Tasks for the team like planning A-Developer-Experience Z-Flaky-Test A test is raising false alarms and removed T-Defect labels May 19, 2023
@kerryarchibald kerryarchibald mentioned this issue May 19, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kerryarchibald kerryarchibald

Labels
A-Developer-Experience T-Task Tasks for the team like planning Z-Flaky-Test A test is raising false alarms
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: cypress findByTestId and percySnapshotElement do not work together matrix-org/matrix-react-sdk
2 participants
@kerryarchibald @luixxiul