Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Modal.closeCurrentModal #27678

Open
dbkr opened this issue Jul 5, 2024 · 0 comments
Open

Remove Modal.closeCurrentModal #27678

dbkr opened this issue Jul 5, 2024 · 0 comments
Labels
A-Dialogs T-Task Tasks for the team like planning

Comments

@dbkr
Copy link
Member

dbkr commented Jul 5, 2024

Your use case

In matrix-org/matrix-react-sdk#12728 I essentially replaced this function with one that force-closes all the active modals, because this was actually what was intended in all the places it was called. However, making the test use it caused a bunch of them to start racing and breaking each other.

It would be great to remove the current hack in test utils that closes all dialogs and replace it with the force close method, de-racing the tests in the process.

Have you considered any alternatives?

No response

Additional context

No response

@dbkr dbkr added the T-Task Tasks for the team like planning label Jul 5, 2024
@dosubot dosubot bot added the A-Dialogs label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Dialogs T-Task Tasks for the team like planning
Projects
None yet
Development

No branches or pull requests

1 participant