Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pasting image into RTE sent both URL and attachment #3475

Closed
ara4n opened this issue Mar 19, 2017 · 11 comments
Closed

pasting image into RTE sent both URL and attachment #3475

ara4n opened this issue Mar 19, 2017 · 11 comments
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Mar 19, 2017

...and the upload confirmation had no focus
@lampholder
Copy link
Member

This worked fine for me on chrome and firefox - pasting an image uploaded without displaying the URL, and the confirmation had focus inasmuch as pressing enter confirmed the upload.

Do you have a link to an example of the URL being uploaded (or a room for me to mine to track it down)?

@lampholder lampholder added the X-Needs-Info This issue is blocked awaiting information from the reporter label Mar 20, 2017
@lampholder
Copy link
Member

Okay, so Matthew demonstrated IRL that there is something peculiar going on here.

To reproduce:

The alt text gets pasted into the text area, stealing the focus from the modal dialogue.

@lampholder lampholder added S-Minor Impairs non-critical functionality or suitable workarounds exist P1 ui/ux and removed X-Needs-Info This issue is blocked awaiting information from the reporter X-Cannot-Reproduce labels Mar 20, 2017
@t3chguy
Copy link
Member

t3chguy commented May 1, 2017

Tried reproducing, copying an image with/without alt text using right click > Copy Image worked fine - nothing got pasted, upload was prompted. Copying an image by highlighting and then Ctrl+C only ever pasted the Alt text (or nothing if none)

Windows 10
Chrome 58.0.3029.81 (64-bit)
riot.im/develop

@ara4n
Copy link
Member Author

ara4n commented May 1, 2017

i wonder if the new modal dialog focus stuff magically fixed this. will check

@lampholder
Copy link
Member

When I tried (Mac, Chrome 58, /develop) I found that copying (right click, copy) the image with alt text:

  • uploaded the image
  • dumped the URL into the text area
  • didn't give the modal focus

The same process for images without alt text worked fine (including focusing the modal)

@lukebarnard1
Copy link
Contributor

I can't repro on Ubuntu/Chrome so I reckon this is platform-specific to macOS.

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Jul 10, 2017 •
edited
Loading

Does anyone who experienced this bug have High DPI enabled? Apparently Chrome had a bug that got fixed in Chome 56 at some point - https://bugs.chromium.org/p/chromium/issues/detail?id=667223

(I realise that @lampholder and @t3chguy are using 58)

@lampholder
Copy link
Member

My macbook air doesn't have high DPI enabled but is still experiencing the problem on Chrome (59 now)

@lampholder lampholder mentioned this issue Aug 2, 2017
Closed
@ara4n ara4n mentioned this issue May 21, 2018
Merged
33 tasks
@t3chguy
Copy link
Member

t3chguy commented Jun 12, 2018

@ara4n does Slate solve this one? (i couldn't reproduce in the first place)

@ara4n
Copy link
Member Author

ara4n commented Jul 16, 2018

it does, which makes my life so much better :)

fixed by matrix-org/matrix-react-sdk#1890

@ara4n ara4n closed this as completed Jul 16, 2018
@t3chguy
Copy link
Member

t3chguy commented Jul 16, 2018

:D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ara4n @lampholder @t3chguy @lukebarnard1