Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replies (minor) snagging list. #6445

Closed
4 of 5 tasks
lampholder opened this issue Apr 4, 2018 · 13 comments
Closed
4 of 5 tasks

Replies (minor) snagging list. #6445

lampholder opened this issue Apr 4, 2018 · 13 comments
Labels
A-Replies reply P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@lampholder
Copy link
Member

lampholder commented Apr 4, 2018

I built and tested the latest m.relates_to branches and hosted it on https://lant.uk/riot/new_replies

Things I tested:

  • Replying to your own message ✅
  • Replying to your own reply ✅
  • Replying to a message from someone else ✅
  • Replying to a reply from someone else ✅
  • Replying to an emote ✅
  • Replying to a picture ✅
  • Replying to a file ✅
  • Not being able to reply with an emote ✅
  • Not being able to reply with a file ⚠️
  • Replying on a narrow screen ⚠️
  • Replying with a single emoji ✅
  • Replying in an E2E room when there are unknown devices in the room ⚠️
  • Representation on today's /app ✅ (In reply to link links to the original message)
  • Representation over IRC bridge ✅ (reply is rendered sensibly)
    screen shot 2018-04-04 at 09 56 53

In conclusion, for the most part it's great and nothing was show-stoppingly broken, but the ⚠️s represent tests where the outcome could have been a little bit better (mostly from a UX perspective).

Issues Identified

  • P1 Reply UX slow to disappear - The replies UX was sometimes slow to disappear (taking ~a second to disappear after the reply has been sent)
  • P2 Replying in an E2E room when there are unknown devices in the room - The current experience is:
    • initiate reply
    • type message
    • click send
    • receive 'unknown devices' prompt (which shows the reply as a red pending message, rather than a reply)
    • click 'send message'
    • message rendered to the timeline as a message
    • a few seconds later, the message appears (correctly) as a reply
  • P2 Replying on a narrow screen - we get a return of the one-character-wide super tallness:
    screen shot 2018-04-04 at 10 00 54
  • P3 Not being able to reply with a file - If you open the reply function then upload a file, the file uploads behind the reply UX (and not as a reply). It is a known limitation of the current impl that we can't reply with a file, but the UX doesn't make that obvious (in the way that it does, say, for our not being able to reply with an emote).
  • P3 Replying with a single emoji - it renders in the small style rather than the usual large style of a single... emojus
@Cadair
Copy link

Cadair commented Apr 4, 2018

I have just been giving this a little test a couple of quick thoughts:

  1. there seems to be no way to click the rendered reply to jump back in the timeline to the location of the original message (to get extra context etc). Where as there is only this on /app currently, it would be nice if the (body of the) reply was clickable to jump back in the timeline imo.

  2. When the in reply to of a reply to a reply is collapsed, the user pill is not clickable, either to take you to that user or to expand the reply. (I was expecting the latter)

Finally, I can't quite put my finger on what it is, but I feel that chains of two+ replies get's a little unclear. It's not visually obvious to me that I am effectively viewing a thread.

@t3chguy
Copy link
Member

t3chguy commented Apr 4, 2018

  1. there is, its clicking the timestamp of the event being replied to, but agreed that is a little obscure
  2. I shall investigate - thanks

@Cadair
Copy link

Cadair commented Apr 4, 2018

forgot to say in the original comment, but this looks awesome and I can't wait to have it!

@t3chguy
Copy link
Member

t3chguy commented Apr 7, 2018

message rendered to the timeline as a message

is VERY weird

@t3chguy
Copy link
Member

t3chguy commented Apr 7, 2018

oh I see why its happening, the local-echo does not include the m.relates_to because it gets stripped off to be put on the envelope event, so the local-echo needs to copy it accross

@t3chguy
Copy link
Member

t3chguy commented Apr 12, 2018

  • there should be a way to collapse the thread when you're done with it

@lampholder lampholder added T-Defect P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Apr 16, 2018
@lampholder
Copy link
Member Author

I've stuck bug p1 major on this because all these minor snags being addressed added up to a major improvement on the replies UX

@t3chguy
Copy link
Member

t3chguy commented May 4, 2018

2. of @Cadair 's thoughts has broken out into #6670

@turt2live
Copy link
Member

Not sure if the design is up for consideration as well, however I'm kinda a fan of this:
image

It feels like it takes up a lot less space, despite only saving a line or two.

@ara4n
Copy link
Member

ara4n commented Jun 10, 2018 via email

@aaronraimist
Copy link
Collaborator

When replying to a /me, the sent time is displayed on top of the avatar Screen Shot 2019-09-27 at 9 59 16 AM

@ghost
Copy link

ghost commented Jun 20, 2020

I'd like the ability to remove user avatars from replies in order to make them much more compact. Any other way of reducing screen space bloat would be appreciated.

Thank you.

@aaronraimist aaronraimist added the A-Replies reply label Mar 27, 2021
@robintown
Copy link
Member

Going off the task list above, it looks like the last outstanding issue has been fixed by matrix-org/matrix-react-sdk#3553. Since the avatar is now removed from the preview, and the preview now stretches across the entirety of the composer, it's much harder to squish replies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Replies reply P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

7 participants