Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline (pagination) performance is noticeably slower than on Element X iOS #4391

Open
frebib opened this issue Mar 11, 2025 · 1 comment · May be fixed by #4399
Open

Timeline (pagination) performance is noticeably slower than on Element X iOS #4391

frebib opened this issue Mar 11, 2025 · 1 comment · May be fixed by #4399
Assignees
@jmartinesp
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@frebib
Copy link
Contributor

frebib commented Mar 11, 2025

Since the event cache has been enabled by default, timeline performance has improved quite a bit. In many cases though, it still feels a lot slower than on iOS. This is in part due to uniffi

As a user, I shouldn't ever really be able to get to the top of a loading timeline (as is on iOS) when in reality I hit the loading spinner almost every time. Pagination should happen so fast that the user never sees the unloaded portion of the timeline.
@jmartinesp
Copy link
Member

FWIW I think we're only actively paginating when the load more indicator is displayed (or prefetched), and this can be way too late. We should probably paginate at 10-20 items before the last one. I'll draft a PR for this.

@jmartinesp jmartinesp added S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Timeline labels Mar 12, 2025
@jmartinesp jmartinesp self-assigned this Mar 12, 2025
@jmartinesp jmartinesp linked a pull request Mar 12, 2025 that will close this issue
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmartinesp jmartinesp

Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add timeline item prefetching element-hq/element-x-android
2 participants
@jmartinesp @frebib