Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements to how we handle and display comic logos #150

Open
elijahcarrel opened this issue Jun 18, 2023 · 0 comments
Open

Various improvements to how we handle and display comic logos #150

elijahcarrel opened this issue Jun 18, 2023 · 0 comments

Comments

@elijahcarrel
Copy link
Owner

elijahcarrel commented Jun 18, 2023

Some of these need to be fixed in code but others are not specific to code

  • Retool re-uploading of the same image to the same s3 location seems to be broken
  • max-age should not be set to 60*60*24*365*2 = 63072000 = two years, or at least we should have some mechanism to bust the cache in order to re-upload images. Not sure how this is getting set so high but see https://nextjs.org/docs/pages/api-reference/components/image#caching-behavior
  • (Should logo images have randomly generated meaningless filepaths rather than meaningful ones? Might fix the above problems.)
  • Have a separate staging s3 bucket
  • Comic logos should be at minimum 200px x 200px to support higher-resolution displays. We can rely on Vercel image optimization to shrink them for smaller screens
  • Make sure to specify width/height so that if we upload a non-square image it doesn't look terrible
  • Maybe switch to png so we can support transparency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant