Check for "maxlength" attribute instead of "maxLength" in "-guard-for-maxlength.ts"

[shubham88fru]

ember-test-helpers/addon-test-support/@ember/test-helpers/dom/-guard-for-maxlength.ts

Line 22 in 7d0aab9

!!Number(element.getAttribute('maxLength')) &&

Hi All,

Shouldn't this piece of code above be doing -

element.getAttribute('maxlength')

(i.e. lowercase 'maxlength').
instead of camelCase 'maxLength' ?

If understand correctly,element represents the DOM element, and if I refer MDN the maximum length attribute is
maxlength and not maxLength

https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/maxlength

[rwjblue]

We can make that change, but it shouldn't make a difference since el.getAttribute calls .toLowerCase() before actually doing any work (MDN docs here).

[shubham88fru]

We can make that change, but it shouldn't make a difference since el.getAttribute calls .toLowerCase() before actually doing any work (MDN docs here).

Ohh I see. Cool. Thanks!

[rwjblue]

Going to close this for now, happy for someone to send a PR though.