Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old compatibility code #1433

Closed
Windvis opened this issue Aug 21, 2023 · 1 comment
Closed

Remove old compatibility code #1433

Windvis opened this issue Aug 21, 2023 · 1 comment

Comments

@Windvis
Copy link

Windvis commented Aug 21, 2023

It seems the addon still contains code for very old (Ember Data) addon compatibility:

For example:

if (has('ember-data/setup-container')) {
// ember-data is a proper ember-cli addon since 2.3; if no 'import
// 'ember-data'' is present somewhere in the tests, there is also no `DS`
// available on the globalContext and hence ember-data wouldn't be setup
// correctly for the tests; that's why we import and call setupContainer
// here; also see https://github.com/emberjs/data/issues/4071 for context
let setupContainer = require('ember-data/setup-container')['default'];
setupContainer(owner);
}

I verified in the Discord and this code should no longer be needed.

A benefit of removing this code is that it still uses loader.js code directly, which is up for removal: emberjs/rfcs#938

@NullVoxPopuli
Copy link
Collaborator

This will be removed in the next major!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants