Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting rule in "resolutions" in root package.json and addon's package.json for rimraf causing failure. #1463

Closed
shubham88fru opened this issue Jul 22, 2024 · 2 comments

Comments

@shubham88fru
Copy link
Contributor

Hi,

I cloned the master branch and tried doing yarn install and then yarn test but seeing the following error -
Screenshot 2024-07-22 at 2 58 08 PM

This seems to be happening because the addon required rimraf version ^5.0.1 -

"rimraf": "^5.0.1",

but the "resolutions" in the root package.json restricts rimraf version to < 5.0.0 -

"rimraf": "< 5.0.0",

because of this, on doing yarn install a lower version of rimraf (version 4.x) is installed, than what is need for the addon module (version 5.x) -
Screenshot 2024-07-22 at 3 04 32 PM

I tried removing the rimraf entry from "resolutions" altogether and was able to run the tests.

Please let me know your thoughts on this. Should I create a PR for this?

@NullVoxPopuli
Copy link
Collaborator

This is solved by this PR: #1453
waiting for review over there.

@shubham88fru
Copy link
Contributor Author

Closing this issue since PR #1453 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants