Module not found: Error: @ember/test-helpers is trying to import from @ember/-internals but that is not one of its explicit dependencies

[mkszepp]

After upgrade to @ember/test-helpers to v4 the addon embroider-safe test is running into this error (see CI error)

Module not found: Error: @ember/test-helpers is trying to import from @ember/-internals but that is not one of its explicit dependencies

The only usecase is here:

ember-test-helpers/addon/src/-internal/render-settled.ts

Lines 9 to 15 in 41e0bb1

	if (macroCondition(dependencySatisfies('ember-source', '>=4.5.0-beta.1'))) {
	//@ts-ignore
	renderSettled = importSync('@ember/renderer').renderSettled;
	} else {
	//@ts-ignore
	renderSettled = importSync('@ember/-internals/glimmer').renderSettled;
	}

It looks like the macroCondition brings a false instead of true...

Maybe the problem is that test-helpers doesn't have ember-source as peerDependency?

The test-app is using ember-source v5.10. I can also reproduce it with v5.11

[NullVoxPopuli]

Thanks for reporting! I have a hunch that this is why I originally did an dependenciesMeta*injected.

Hopefully, if I re-add that, tests will fail

[CvX]

We had the same @ember/-internals error in Discourse (failed CI run) and now on 4.0.1 there's a @ember/renderer error instead 😅 (CI)

[NullVoxPopuli]

hm, @ember/renderer is from ember-source, so I feel like this could be an embroider bug 🤔 I'll try a repro tomorrow

[mkszepp]

Confirm.. i have the same error in EBD (with clean install) see CI

[Turbo87]

same in crates.io (see rust-lang/crates.io#9302)