Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module not found: Error: @ember/test-helpers is trying to import from @ember/-internals but that is not one of its explicit dependencies #1481

Closed
mkszepp opened this issue Aug 22, 2024 · 5 comments · Fixed by #1482 or #1487

Comments

@mkszepp
Copy link

mkszepp commented Aug 22, 2024

After upgrade to @ember/test-helpers to v4 the addon embroider-safe test is running into this error (see CI error)

Module not found: Error: @ember/test-helpers is trying to import from @ember/-internals but that is not one of its explicit dependencies

The only usecase is here:

if (macroCondition(dependencySatisfies('ember-source', '>=4.5.0-beta.1'))) {
//@ts-ignore
renderSettled = importSync('@ember/renderer').renderSettled;
} else {
//@ts-ignore
renderSettled = importSync('@ember/-internals/glimmer').renderSettled;
}

It looks like the macroCondition brings a false instead of true...

Maybe the problem is that test-helpers doesn't have ember-source as peerDependency?

The test-app is using ember-source v5.10. I can also reproduce it with v5.11

@NullVoxPopuli
Copy link
Collaborator

Thanks for reporting! I have a hunch that this is why I originally did an dependenciesMeta*injected.

Hopefully, if I re-add that, tests will fail

@CvX
Copy link
Contributor

CvX commented Aug 23, 2024

We had the same @ember/-internals error in Discourse (failed CI run) and now on 4.0.1 there's a @ember/renderer error instead 😅 (CI)

@NullVoxPopuli
Copy link
Collaborator

NullVoxPopuli commented Aug 23, 2024

hm, @ember/renderer is from ember-source, so I feel like this could be an embroider bug 🤔 I'll try a repro tomorrow

@mkszepp
Copy link
Author

mkszepp commented Aug 23, 2024

Confirm.. i have the same error in EBD (with clean install) see CI

@Turbo87
Copy link
Member

Turbo87 commented Aug 23, 2024

same in crates.io (see rust-lang/crates.io#9302)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants