-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node.js #96
Comments
+1 for 8.x over the others, as it has mostly complete ES6 feature support. |
(Also as a data point, I've been using Node 8.x with emscripten for a while now with no problems) |
Yeah, it sounds like a due time to update. I'll try to make this happen shortly. |
+1 for 8.x as it has become LTS as of the 31st of October. |
@juj any update regarding this issue? It is causing some really annoying problems as most of the newer scaffolding tools use ES2015+ javascript in Node.js which is not supported in earlier versions. In my opinion it would be better to move away from including Node.js in the build because when activating Emscripten it overrides the existing Node binding resulting in issues with other packages. |
Yeah, I think it'd be more convenient if |
Ops, sorry, this was resolved a couple of weeks ago in 9026335, but forgot to link to this issue. We can't really drop node.js from emsdk install sdk-1.37.22-64bit you can specify emsdk install emscripten-tag-1.37.22-64bit binaryen-tag-1.37.22-64bit clang-tag-e1.37.22-64bit Unfortunately though at present, there does not exist emsdk install emscripten-incoming-64bit binaryen-master-64bit clang-incoming-64bit to avoid getting node or python. Does that help? |
Thank you, I wasn't aware of the ability to install without Node.js. Great to see that Node has been updated to 8.9.1 👍 . |
Nice, that's great news about the Node version update. As far as the different installable tools, I'm aware of that, but in this case I'm using emsdk in a bash script that just needs to get the latest of everything needed to make emscripten work without knowing what that is or what the version numbers are. This is the best workaround I've come up with:
It'd be preferable medium-to-long-term if emsdk's Node.js could just be used by emscripten without taking a higher priority in my PATH than the one in /usr/bin, or if it could detect when the installed Node.js version is sufficient for the current emscripten and do roughly what my script currently does, but as long as we can reliably expect it to be the latest LTS release then it's basically fine for my purposes for now. |
Currently emsdk uses Node.js 4.1.1, which is quite old and doesn't support some of the newer features required by JS version of Closure Compiler in order to implement emscripten-core/emscripten#5464
Closure Compiler JS should be happy with latest release of the same v4 LTS branch, but would be also nice to upgrade it to v6 LTS or even v8 (which is planned to be LTS as well) for more performance and future-proofness.
If this is not a big undertaking, I'd be thankful for including newer Node.js version into next release.
The text was updated successfully, but these errors were encountered: