Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envoy is failing with Bazel@HEAD #28719

Closed
sgowroji opened this issue Jul 31, 2023 · 7 comments
Closed

Envoy is failing with Bazel@HEAD #28719

sgowroji opened this issue Jul 31, 2023 · 7 comments
Labels
triage Issue requires triage

Comments

@sgowroji
Copy link

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3202#0189a9b6-75b5-44c3-b395-c4864f10c8ce

Platform : Linux

Logs:

ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/88bf210a2b284b3a14eecfe4138c4fc3/external/com_google_protobuf/BUILD.bazel:275:11: Target '@com_google_protobuf//src/google/protobuf/compiler:importer' contains an error and its package is in error and referenced by '@com_google_protobuf//:protobuf'
(02:18:08) ERROR: Analysis of target '//test/integration:filter_manager_integration_test' failed; build aborted: Analysis failed
(02:18:08) INFO: Elapsed time: 7.569s
(02:18:08) INFO: 0 processes.
(02:18:08) ERROR: Build did NOT complete successfully

Steps :

git clone  https://github.com/envoyproxy/envoy.git
git reset 1b01f90c074a410393cea6cb2fdf0ee077416957 --hard
export USE_BAZEL_VERSION=f771739efcdde7b08de46c746d8dd909ae59fc83
bazel test --config=remote-clang-libc++ --config=remote-ci --define=wasm=disabled --jobs=75  //test/common/common/... //test/integration/... //test/exe/...

CC Greenteam @meteorcloudy

@sgowroji sgowroji added the triage Issue requires triage label Jul 31, 2023
@meteorcloudy
Copy link
Contributor

@sgowroji Can you try to bisect and identify which Bazel commit caused the breakage?

@meteorcloudy
Copy link
Contributor

A bisect points to bazelbuild/bazel@c061e57, which matches the error message:

ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/88bf210a2b284b3a14eecfe4138c4fc3/external/com_google_protobuf/src/google/protobuf/compiler/BUILD.bazel:140:13: @com_google_protobuf//src/google/protobuf/compiler:protoc_aarch64_test_genrule: no such attribute 'exec_tools' in 'genrule' rule (did you mean 'executable'?)

@meteorcloudy
Copy link
Contributor

meteorcloudy commented Jul 31, 2023

/cc @katre, I'll rollback the breaking change to reduce damage for downstream pipeline.

@phlax
Copy link
Member

phlax commented Jul 31, 2023

Reading

no such attribute 'exec_tools' in 'genrule'

im wondering if we should update all instances of exec_tools -> tools

@katre
Copy link

katre commented Jul 31, 2023

Yes, you should do this migration: bazelbuild/bazel#19132

@phlax
Copy link
Member

phlax commented Jul 31, 2023

#28729

@phlax
Copy link
Member

phlax commented Aug 1, 2023

closing this as we have now updated the exec_tools throughout the codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Issue requires triage
Projects
None yet
Development

No branches or pull requests

4 participants