Remove unused property from ErtNotifier

Author: oyvindeide

src/ert/gui/ertnotifier.py

@@ -10,9 +10,8 @@ class ErtNotifier(QObject):
     storage_changed = Signal(object, name="storageChanged")
     current_ensemble_changed = Signal(object, name="currentEnsembleChanged")
 
-    def __init__(self, config_file: str):
+    def __init__(self) -> None:
         QObject.__init__(self)
-        self._config_file = config_file
         self._storage: Storage | None = None
         self._current_ensemble: Ensemble | None = None
         self._is_simulation_running = False
@@ -26,10 +25,6 @@ def storage(self) -> Storage:
         assert self.is_storage_available
         return self._storage  # type: ignore
 
-    @property
-    def config_file(self) -> str:
-        return self._config_file
-
     @property
     def current_ensemble(self) -> Ensemble | None:
         if self._current_ensemble is None and self._storage is not None:

src/ert/gui/main_window.py

@@ -88,7 +88,7 @@ def __init__(
         log_handler: GUILogHandler | None = None,
     ):
         QMainWindow.__init__(self)
-        self.notifier = ErtNotifier(config_file)
+        self.notifier = ErtNotifier()
         self.plugins_tool: PluginsTool | None = None
         self.ert_config = ert_config
         self.config_file = config_file

tests/ert/ui_tests/gui/test_manage_experiments_tool.py

@@ -28,7 +28,7 @@
 def test_init_prior(qtbot, storage):
     config = ErtConfig.from_file("poly.ert")
     config.random_seed = 1234
-    notifier = ErtNotifier(config.config_path)
+    notifier = ErtNotifier()
     notifier.set_storage(storage)
     ensemble = storage.create_experiment(
         parameters=config.ensemble_config.parameter_configuration,
@@ -62,7 +62,7 @@ def test_init_prior(qtbot, storage):
 @pytest.mark.usefixtures("copy_poly_case")
 def test_that_init_updates_the_info_tab(qtbot, storage):
     config = ErtConfig.from_file("poly.ert")
-    notifier = ErtNotifier(config.config_path)
+    notifier = ErtNotifier()
     notifier.set_storage(storage)
 
     ensemble = storage.create_experiment(
@@ -132,7 +132,7 @@ def test_experiment_view(
     config = snake_oil_case_storage
     storage = snake_oil_storage
 
-    notifier = ErtNotifier(config.config_path)
+    notifier = ErtNotifier()
     notifier.set_storage(storage)
 
     tool = ManageExperimentsPanel(
@@ -164,7 +164,7 @@ def test_ensemble_view(
     config = snake_oil_case_storage
     storage = snake_oil_storage
 
-    notifier = ErtNotifier(config.config_path)
+    notifier = ErtNotifier()
     notifier.set_storage(storage)
 
     tool = ManageExperimentsPanel(
@@ -303,7 +303,7 @@ def _evaluate(coeffs, x):
     prior_ens, _ = run_cli_ES_with_case("poly_localization_0.ert")
     config = ErtConfig.from_file("poly_localization_0.ert")
 
-    notifier = ErtNotifier(config.config_path)
+    notifier = ErtNotifier()
     with open_storage(config.ens_path, mode="w") as storage:
         notifier.set_storage(storage)
 
@@ -349,7 +349,7 @@ def _evaluate(coeffs, x):
 @pytest.mark.usefixtures("copy_poly_case")
 def test_ensemble_observations_view_on_empty_ensemble(qtbot):
     config = ErtConfig.from_file("poly.ert")
-    notifier = ErtNotifier(config.config_path)
+    notifier = ErtNotifier()
     with open_storage(config.ens_path, mode="w") as storage:
         notifier.set_storage(storage)
         storage.create_experiment(
@@ -413,7 +413,7 @@ def test_realization_view(
     config = snake_oil_case_storage
     storage = snake_oil_storage
 
-    notifier = ErtNotifier(config.config_path)
+    notifier = ErtNotifier()
     notifier.set_storage(storage)
 
     tool = ManageExperimentsPanel(

tests/ert/unit_tests/gui/ertwidgets/test_ensembleselector.py

@@ -1,6 +1,6 @@
 import pytest
 
-from ert.config import ErtConfig, GenDataConfig, GenKwConfig
+from ert.config import GenDataConfig, GenKwConfig
 from ert.config.gen_kw_config import TransformFunctionDefinition
 from ert.gui.ertnotifier import ErtNotifier
 from ert.gui.ertwidgets.ensembleselector import EnsembleSelector
@@ -27,7 +27,7 @@ def response():
 
 @pytest.fixture
 def notifier():
-    return ErtNotifier(ErtConfig())
+    return ErtNotifier()
 
 
 def test_empty(qtbot, notifier):