Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Add search for tabs with ITLD sites (punycode) #129

Open
belonesox opened this issue Jun 3, 2024 · 1 comment
Open

[RFE] Add search for tabs with ITLD sites (punycode) #129

belonesox opened this issue Jun 3, 2024 · 1 comment

Comments

@belonesox
Copy link

belonesox commented Jun 3, 2024

Consider a user that try to find a site with international TLD, like моника.гафгаф.рф
Using keyword "гафгаф" she cannot find the tab using tabhunter now.

Please, add fuzzy search, converting keywords to punycode, so
гафгафxn--80aahb8fc and she will found the tab with xn--80apggff.xn--80aahb8fc.xn--p1ai (моника.гафгаф.рф)

@ericpromislow
Copy link
Owner

I might make this change if no external pull request comes in, but I'll need someone to test the PR. That someone will probably be you, since you have a github account and clearly can program. Building tabhunter and loading a test build into firefox or chrome is documented and straightforward.

Note to self: Most likely the buildMatchedItemsArray function will need to be changed. If the pattern match at line 783 fails convert it to punycode and retry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants