From 8c165e058e4f731b9b4b8a96fb1b8180a6c74942 Mon Sep 17 00:00:00 2001 From: Tristan Sloughter Date: Mon, 18 Nov 2024 05:03:49 -0700 Subject: [PATCH 1/2] export query/4 to support manually passing connection --- src/pgo.erl | 1 + test/pgo_basic_SUITE.erl | 12 +++++++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/pgo.erl b/src/pgo.erl index c766acd..d08a259 100644 --- a/src/pgo.erl +++ b/src/pgo.erl @@ -13,6 +13,7 @@ query/1, query/2, query/3, + query/4, transaction/1, transaction/2, transaction/3, diff --git a/test/pgo_basic_SUITE.erl b/test/pgo_basic_SUITE.erl index b89418f..e089ac8 100644 --- a/test/pgo_basic_SUITE.erl +++ b/test/pgo_basic_SUITE.erl @@ -22,7 +22,8 @@ cases() -> rows_as_maps, json_jsonb, types, int4_range, ts_range, tstz_range, numerics, hstore, records, circle, path, polygon, line, - line_segment, tid, bit_string, arrays, tsvector]. + line_segment, tid, bit_string, arrays, tsvector, + query_arity_4]. init_per_suite(Config) -> application:load(pg_types), @@ -437,3 +438,12 @@ tsvector(_Config) -> pgo:query("SELECT $1::tsvector", [[{<<"a">>,[{1,'A'}]}, {<<"cat">>,[{5,null}]}, {<<"fat">>,[{2,'B'},{4,'C'}]}]])). + +query_arity_4(_Config) -> + {ok, Ref, Conn} = pgo:checkout(default), + + ?assertMatch(#{rows := [{1}]}, pgo:query("select 1", [], #{}, Conn)), + + pgo:checkin(Ref, Conn), + + ok. From e06c77e963ba41b49886b3a873ad21fe6adbd28e Mon Sep 17 00:00:00 2001 From: Tristan Sloughter Date: Mon, 18 Nov 2024 05:10:22 -0700 Subject: [PATCH 2/2] add changelog entry for export/4 --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 38c9389..a1b5ba5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,8 @@ - Support unix domain socket host names [#90](https://github.com/erleans/pgo/pull/90) +- Export `pgo:query/4` to support passing a connection directly to `query` + [#95](https://github.com/erleans/pgo/pull/95) ### Fixed