Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release? #67

Closed
KristofferC opened this issue Jul 13, 2020 · 6 comments
Closed

New release? #67

KristofferC opened this issue Jul 13, 2020 · 6 comments

Comments

@KristofferC
Copy link
Collaborator

#63 has been on master for quite a while now so perhaps it is time to make a new release with it.

The question is if it should be a 3.0 or 2.9 release. I think the current version should be fairly non-breaking compared to the last one (looking at the few tests that needed changing) but I think there are some differences when it comes to when arithmetic on vector of Bools are allowed etc.

cc @tkf, @eschnett

@eschnett
Copy link
Owner

I'm happy to make a new release. I tend to strictly follow the SerVer rules: If there is a breaking change, it's a new major version, otherwise a minor version. Can you give an example of what arithmetic is now not allowed any more?

@KristofferC
Copy link
Collaborator Author

Bool isn't really considered an arithmetic type now:

julia> a = Vec(true, false, true, false)
<4 x Bool>[1, 0, 1, 0]

julia> a+a
ERROR: MethodError: no method matching +(::Vec{4,Bool}, ::Vec{4,Bool})

@eschnett
Copy link
Owner

I tend towards a major release then. Would you object?

@tkf
Copy link
Contributor

tkf commented Jul 13, 2020

(Just FWIW I'm OK with either choice)

@eschnett
Copy link
Owner

@KristofferC Do you want to do the honour of releasing 3.0?

@KristofferC
Copy link
Collaborator Author

Sure, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants